fix not using a ConsumingFanOut when connecting the two poll-types each with a push-type variable (e.g. control system)

this happens frequently when following the modern connectTo() logic and connecting everything with the control system.

- The direction cannot be determined from the accessor which is being decorated
- Fixed wrong usage of feeding/consuming in Applicaton::createDeviceVariable. Was used consistently wrong, so there was no behaviour bug. But the code was confusing because the direction was wrong.

Tests still failing.

This partly reverts the last commit as would trigger writeAll from
typedMtypedMakeConnections and causes errors.

  - EntityOwner has individual counters for both events
  - Adapted all instances of increment/decrementDataFaultCounter
  - Not changed getDataValidity() implementation yet
  - Tests failing

- first part of #102
- Existing tests passing
- New tests not activated yet

- remove "void ExceptionHandlingDecorator::setDataValidity(DataValidity newValidity)"
- add "void ExceptionHandlingDecorator::setOwner(EntityOwner* owner)" and remove owner setting in constructor

  - Cleanup:

    - Reorder code in Application::createDeviceVariable
    - Separated ExceptionHandlingDecorator constructors for writable and
      non-writable registers
    - cleaned up doPreWrite

  - First compiling version, tests pass, hope it works...
  - Needs some tweaking

wip: fix propagation of initial values from control system variables (persistence layer) and device registers (just the current value)

Moved setting the initial version number for all ApplicationModules from Application::initialise() to Application::run(), so the version numbers of the persisted values from the control system are smaller.

changed: deviceModule run is called before readLatest for comusming direction variables.
removed: impl->write() for NodeType::Device.

Test still does not work.
-Unable to get the exception status for the device throwing exception.
-Second device only works it has it's own trigger.

- removed debug output
- made implementation for not-fixed feeders (i.e. ApplicationModule feeders) of the trigger network identical to the implementation for fixed feeders

TriggerFanOut must catch exceptions when reading from the TransferGroup, since this cannot be handled by the decorator

Martin Killenberg authored 5 years ago and Martin Christoph Hierholzer committed 5 years ago

Creation of fanOuts is based on externalTriggerImpl (=trigger consumer), not externalTriggerNode (=trigger feeder).
- Fixes connection network but not exception handling.
- Lots of debug output left in the code for further investigation.

  DeviceModule and ControlSystemModule now do not take the optional prefix argument in their constructors any more. Use the [] operator instead to get the submodule.

- Add ExceptionHandlingDecorator and decorate all device variables with it.