ProcessVariableProxy::removeNode() was effectively taking a reference to
a shared pointer as an argument and is removing the same (effective)
shared pointer from a list. This poses a problem if the reference passed
points to the list directly and is the last shared pointer to this
object so it gets freed, because removeNode() is accessing the object
after removing it from the list.

BREAKING CHANGE:
Since previously more characters were allowed (with possibly adverse
effects), this commit may force application developers and/or system
integrators to take action by changing variable names such that they
comply to the rules. Only alphanumeric characters and the underscore
are allowed, while slashes (and dots) are understood as hierarchy
separators.

- fix EntityOwner::constant() violates character restrictions
- Utilities::stripName() was broken in multiple ways. It has been
  changed into a true, reversible escaping algorithm and subsequently
  renamed into Utilities::escapeName().
- Utilities::unescapeName() is introduced.

BREAKING CHANGE: This commit will break applications which either
- rely on the names of device status PVs for devices which contain
  illegal characters (e.g. when using a CDD directly instead of a
  dmap file alias), or
- use Utilities::stripName() directly.

* Disable deprecation warnings
* Fix linter findings
* fix: Compiler warnings regarding internal linkage
* fix: Mask memory leak

---------

Co-authored-by: Martin Hierholzer <martin.hierholzer@desy.de>

InvalidityTracer and ConnectionMaker debug mode print now information
about circular networks

Constants (as generated by ApplicationModule::constant()) were causing a
logic_error if accessors of different types were using the same constant
(created with the same value and the same value type upon creation).
This is possible since the type passed to constant() does not have to be
the same as the type of the accessor.

This is now fixed by giving each constant a fully unique name, so every
accessor using a constant will be in its own little variable network.

This is the implementation for the specification change done in a recent
commit.

May occur when not mapping a Void variable in the control system so it
is being optimised out.

This happens if the control system adapter optimises out the PV.

A PV which is received by a module and also used as a trigger for a
DeviceModule was "deleted" from the model, if the module is unregistered
from its owner. This deletion is now prevented by adding a trigger
relationship to the model (which was anyway missing).

Note: the "deletion" never was a real deletion, instead only all
relationships are removed. As a consequence, the DeviceModule was still
pointing to the "deleted" vertex resulting in a wrong connection later.

* Use correct of version pthread_setname_np depending on platform.

On Linux, this function takes two parameters. On most other platforms
(including all BSD-based platforms) it only takes a single parameter.

* Omit -Wl,--export-dynamic flag on macOS.

This flag is not supported on Clang / LLVM and on macOS it is not needed
anway because exporting all symbols is the default behavior.

When using Clang on other platforms (e.g. Linux) --export_dynamic or
-rdynamic might have to be specified instead.

* clang compiler compatibility

Co-authored-by: Sebastian Marsching <sebastian.marsching-git-2016@aquenos.com>

Jens Georg authored 2 years ago and Martin Christoph Hierholzer committed 2 years ago

Previously we could create applications without PV manager if there were
no connections to the CS. Now with the new connecting scheme, this will
always be the case so we need to have a PV manager by the time
initialise (the place where the connections happen) is called.