Modifying the model while visiting is not allowed because the
modification invalidates the iterators used for visiting. This lead in
this case to a very subtle crash (segfault) only appearing under very
specific circumstances (only when running in ctest and only on some
Ubuntu 20.04 machines).

ProcessVariableProxy::removeNode() was effectively taking a reference to
a shared pointer as an argument and is removing the same (effective)
shared pointer from a list. This poses a problem if the reference passed
points to the list directly and is the last shared pointer to this
object so it gets freed, because removeNode() is accessing the object
after removing it from the list.

chore(project-template): remove workaround for doocstiminglib

Dietrich Rothe authored 1 year ago and Martin Christoph Hierholzer committed 1 year ago

Handle doocstiminglib like other doocs packages, since it now provides
a proper pkgconfig.

The VersionInfoProvider registers with the Application, so we can find
the (singleton-like) instance in the Application. If it is destroyed
for whatever reason, this instance pointer must be de-registered to
prevent use-after-free as well as allow the subsequent creation of
another VersionInfoProvider.

If the StatusAggregator would propagate the DataValidity of its inputs
normally, device errors (runtime exceptions) will normally be presented
as an invalid because values from the device will be aggregated  often
with the same StatusAggregator (if it is on the top level of the app).
This is clearly undesired.

The StatusAggregator did not pass on messages unless the
StatusWithMessage was from another StatusAggregator. StatusWithMessage
outputs from normal modules were treated like normal StatusOutputs
without message.

feat(project-template): add VersionInfo.h generation (#40)

vaeng authored 1 year ago and Martin Christoph Hierholzer committed 1 year ago

* The example app has been updated to show the implementation of the
new VersionInfoProvider module

fix(project-template): remove conflicting llwm-include-order

A different include style is defined in .clang-format

BREAKING CHANGE:
Since previously more characters were allowed (with possibly adverse
effects), this commit may force application developers and/or system
integrators to take action by changing variable names such that they
comply to the rules. Only alphanumeric characters and the underscore
are allowed, while slashes (and dots) are understood as hierarchy
separators.

- fix EntityOwner::constant() violates character restrictions
- Utilities::stripName() was broken in multiple ways. It has been
  changed into a true, reversible escaping algorithm and subsequently
  renamed into Utilities::escapeName().
- Utilities::unescapeName() is introduced.

BREAKING CHANGE: This commit will break applications which either
- rely on the names of device status PVs for devices which contain
  illegal characters (e.g. when using a CDD directly instead of a
  dmap file alias), or
- use Utilities::stripName() directly.

feat(project-template): clang-tidy targets

Jens Georg authored 1 year ago and Martin Christoph Hierholzer committed 1 year ago

* Add clang-tidy targets to project

 - add .clang-tidy file containing our settings and some configs
   according to our coding guidelines
 - add three explicit targets for calling just lint or lint-and-fix, lint-and-fix-and-commit-after-each-fix
 - add enable-able support for CMake"s "native" clang-tidy support (makes
   build super-slow)

* Disable deprecation warnings
* Fix linter findings
* fix: Compiler warnings regarding internal linkage
* fix: Mask memory leak

---------

Co-authored-by: Martin Hierholzer <martin.hierholzer@desy.de>