Skip to content
Snippets Groups Projects

fix: correct latching of manager motor control signals

Merged Michael Randall requested to merge motor_ctrl_latch into a7_m2s
All threads resolved!
  • Moved latching for local motor control signals of manager module into TX part of m2s interface.

I thought that the M2S-TX-FSM is the best place to latch the section of motor control signals that the manager should use for its motors. If you agree, could you please cross-check the solution?

Merge request reports

Merged by Michael RandallMichael Randall 6 months ago (Sep 11, 2024 6:54am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Cagil Guemues added 1 commit

    added 1 commit

    • c69c5958 - fix: wrong output port assignment on the M2S Rx side

    Compare with previous version

  • With the !35 (c69c5958) commit, I can now confirm that M2S path is working correctly now on simulations.

    There is still a TODO: Do not rely on 100 MHz clock for S2M Clock failure detection logic.

  • Cagil Guemues resolved all threads

    resolved all threads

  • All right, thanks. Just create a new branch for removing the 100 MHz clock.

  • Michael Randall marked this merge request as ready

    marked this merge request as ready

  • mentioned in commit 96627f99

  • Please register or sign in to reply
    Loading