Skip to content
Snippets Groups Projects
  1. Jan 06, 2014
  2. Dec 19, 2013
  3. Dec 18, 2013
  4. Dec 17, 2013
  5. Dec 16, 2013
  6. Dec 13, 2013
  7. Dec 12, 2013
    • Eric Cano's avatar
      Catching up with master branch. · 7851ce72
      Eric Cano authored
      7851ce72
    • Eric Cano's avatar
      Fixed inheritance from std::exception (const correctness of what()). This... · 538fa54d
      Eric Cano authored
      Fixed inheritance from std::exception (const correctness of what()). This required declaring m_what mutable.
      Created a multithreaded unit test.
      Created an automatic exception thrower for unhandled errors.
      Ported from previous proof of concept the threading primitves and made them production level (with error checking).
      Added unit tests for threading primitives.
      538fa54d
    • Steven Murray's avatar
      Attempt to fix a compilation bug surrounding the uninitialized local variable... · 50efc4a0
      Steven Murray authored
      Attempt to fix a compilation bug surrounding the uninitialized local variable named len of the method castor::log::Log::writeMsg
      50efc4a0
    • Steven Murray's avatar
      After discussions with Eric I have removed the singleton pattern from the · 95b30b65
      Steven Murray authored
      implementation of the proposal for a new CASTOR logging system API.
      
      The new API provides a Log class which contains a mutex that mirrors the
      previous locking strategy of Sebastien and Denis.  My additional singleton mutex
      and functionality should not be in the logging API.  Giuseppe and Sebastien
      should decide how the logging API is exposed to subclasses of CASTOR classes
      such as Server and Daemon.  The loggin API should concentrate on logging.
      
      By the way, instantiating two Log objects is not actually a problem, they will
      simply have separate connections to syslog, that's all.
      95b30b65
    • Steven Murray's avatar
      After discussion with Giuseppe I have added two improvements that he has · df972b95
      Steven Murray authored
      kindly suggested.
      
      Firstly the instance() method assumes that destroyInstance() is not called
      concurrently with it so it can assume that in a multi-threaded scenario there is
      a single transition from s_instance being NULL to s_instance pointing to a newly
      created Log object.  This means the following mutex-less if statement can be at
      the beginning of the instance() method to increase performance:
      
        if(NULL != s_instance) {
          return *s_instance;
        }
      
      Secondly the destructor of the Log class should be private in order to prevent
      clients from being able to directly delete the Log singleton.
      df972b95
    • Steven Murray's avatar
      I have changed the design of the proposed new CASTOR logging API, from a C like · e6ea621c
      Steven Murray authored
      collection of functions within a castor::log namespace to a more object
      oriented Singleton pattern.  Pleae note that the code is still far from
      finished, I am commit (compiling) code early in an attempt to increase feedback.
      e6ea621c
  8. Dec 11, 2013
  9. Dec 09, 2013
  10. Dec 06, 2013
Loading