Skip to content

cxx: replace SatelliteImplementation with BaseSatellite

Stephan Lachnit requested to merge p-base-satellite into main

This MR closes #92 (closed)

TODO:

  • Rename test_satellite_implementation.cpp
  • Fix clang-tidy
  • Should we expose the FSM? E.g. to register state callbacks outside of the framework
  • Check some of the function names (e.g. getPort should now probably be getCSCPPort, etc)

Wrt to inheritance for !178 (closed): I actually think that we do have to create SendingSatellite and ReceivingSatellite classes that inherit from Satellite - this is the only way to dynamically cast down as far as my testing goes. Maybe we can create a diamond inheritance, but let's discuss this elsewhere.

Edited by Stephan Lachnit

Merge request reports

Loading