Skip to content
Snippets Groups Projects
  1. Jun 04, 2024
    • Marc-Olivier Andrez's avatar
      build: enable compiling tests not in debug mode (and without code coverage) · 6cc7eb6f
      Marc-Olivier Andrez authored
      Below is the type of compilation error I was getting:
      
      ```
      $ cmake -G Ninja ../.. -DPython_EXECUTABLE=python3.7 -DBUILD_TESTS=ON -DENABLE_COVERAGE=ON -DBUILD_CPP_DOCS=ON -DBUILD_PYTHON_DOCS=ON
      ...
      $ ninja
      [54/174] Building CXX object producer/api/cpp/CMakeFiles/test-asapo-producer.dir/unittests/test_producer_impl.cpp.o
      FAILED: producer/api/cpp/CMakeFiles/test-asapo-producer.dir/unittests/test_producer_impl.cpp.o
      ccache /usr/bin/c++  -I/home/marc-olivier/Documents/desy/dev/gitlab.desy.de/asapo/asapo/producer/api/cpp/include -I/home/marc-olivier/Documents/desy/dev/gitlab.desy.de/asapo/asapo/producer/api/cpp/../c/include -I/home/marc-olivier/Documents/desy/dev/gitlab.desy.de/asapo/asapo/common/cpp/include -g -O0 --coverage -fprofile-arcs -ftest-coverage -Wall -Wextra -pedantic -Wconversion -Wno-missing-field-initializers -fPIC -DGTEST_HAS_PTHREAD=1 -std=gnu++11 -MD -MT producer/api/cpp/CMakeFiles/test-asapo-producer.dir/unittests/test_producer_impl.cpp.o -MF producer/api/cpp/CMakeFiles/test-asapo-producer.dir/unittests/test_producer_impl.cpp.o.d -o producer/api/cpp/CMakeFiles/test-asapo-producer.dir/unittests/test_producer_impl.cpp.o -c /home/marc-olivier/Documents/desy/dev/gitlab.desy.de/asapo/asapo/producer/api/cpp/unittests/test_producer_impl.cpp
      In file included from /home/marc-olivier/Documents/desy/dev/gitlab.desy.de/asapo/asapo/producer/api/cpp/unittests/test_producer_impl.cpp:15:
      /home/marc-olivier/Documents/desy/dev/gitlab.desy.de/asapo/asapo/producer/api/cpp/unittests/mocking.h:20:14: error: ‘uint64_t asapo::MockDiscoveryService::UpdateFrequency()’ marked ‘override’, but does not override
         20 |     uint64_t UpdateFrequency() override {
            |              ^~~~~~~~~~~~~~~
      ```
      6cc7eb6f
    • Marc-Olivier Andrez's avatar
      style: ensure that files terminate with empty new line using `pre-commit` · 58c48bd3
      Marc-Olivier Andrez authored
      As mentioned on
      https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline
      and
      https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206,
      POSIX defines a line as
      
      > A sequence of zero or more non- <newline> characters plus a terminating <newline>
      > character.
      
      When a file does not terminate with an empty line, `Git` commands such
      as `git diff` show the message `No newline at end of file`.
      
      This commit adds a CI job `pre-commit` to enforce the formatting.
      58c48bd3
  2. May 21, 2024
  3. Dec 01, 2023
  4. Nov 23, 2022
  5. Sep 09, 2022
  6. Mar 18, 2022
  7. Feb 23, 2022
  8. Feb 17, 2022
  9. Feb 16, 2022
  10. Jan 27, 2022
  11. Jan 25, 2022
  12. Jan 24, 2022
  13. Jan 21, 2022
  14. Jan 04, 2022
  15. Dec 11, 2021
  16. Dec 06, 2021
  17. Dec 04, 2021
  18. Dec 03, 2021
  19. Nov 09, 2021
  20. Oct 20, 2021
  21. Sep 28, 2021
  22. Aug 04, 2021
  23. Jul 16, 2021
  24. Jul 15, 2021
  25. Jul 09, 2021
  26. Jul 08, 2021
  27. Jul 07, 2021
  28. Jul 06, 2021
  29. Jul 01, 2021
  30. Jun 30, 2021
Loading