Skip to content
Snippets Groups Projects
  1. Jul 01, 2024
  2. Jun 25, 2024
    • Marc-Olivier Andrez's avatar
      build: enable building from a directory which is not a subdirectory of the source directory · 16de7cd3
      Marc-Olivier Andrez authored
      Rationale: building `ASAP::O` from a Docker image on macOS inside a
      subdirectory of the source directory can be slow because the files
      inside the subdirectory are visible from macOS and macOS does not seem
      to handle well when many files changed within a virtual machine. It is
      therefore faster to compile from a directory that is not mounted on the
      Docker image, which cannot be a subdirectory of the source directory.
      16de7cd3
  3. Jun 13, 2024
    • Marc-Olivier Andrez's avatar
      build: use value of environment variable `Python_EXECUTABLE` in CMake scripts · 1934ab68
      Marc-Olivier Andrez authored
      Providing the value of `Python_EXECUTABLE` using an environmnet variable
      instead of a CMake argument can simplify calls to CMake:
      
      ```sh
      cmake .. -DENABLE_LIBFABRIC=ON -DCMAKE_BUILD_TYPE="Release" \
        -DBUILD_CLIENTS_ONLY=ON -DBUILD_PYTHON_PACKAGES=source \
        -DNUMPY_VERSION=$NUMPY_VERSION -DPython_EXECUTABLE=python3
      
      export Python_EXECUTABLE=python3
      cmake .. -DENABLE_LIBFABRIC=ON -DCMAKE_BUILD_TYPE="Release" \
        -DBUILD_CLIENTS_ONLY=ON -DBUILD_PYTHON_PACKAGES=source \
        -DNUMPY_VERSION=$NUMPY_VERSION
      ```
      1934ab68
    • Marc-Olivier Andrez's avatar
      build: use same Python interpreter in all CMake scripts · 01a68a4b
      Marc-Olivier Andrez authored
      This avoids using different Python interpreters for different tasks and
      therefore avoid surprises.
      
      Note: CMake files for Windows were not fixed because no Windows
      CI runner checks that `ASAP::O` compiles on Windows.
      01a68a4b
  4. Jun 04, 2024
    • Marc-Olivier Andrez's avatar
      build: enable compiling tests not in debug mode (and without code coverage) · 6cc7eb6f
      Marc-Olivier Andrez authored
      Below is the type of compilation error I was getting:
      
      ```
      $ cmake -G Ninja ../.. -DPython_EXECUTABLE=python3.7 -DBUILD_TESTS=ON -DENABLE_COVERAGE=ON -DBUILD_CPP_DOCS=ON -DBUILD_PYTHON_DOCS=ON
      ...
      $ ninja
      [54/174] Building CXX object producer/api/cpp/CMakeFiles/test-asapo-producer.dir/unittests/test_producer_impl.cpp.o
      FAILED: producer/api/cpp/CMakeFiles/test-asapo-producer.dir/unittests/test_producer_impl.cpp.o
      ccache /usr/bin/c++  -I/home/marc-olivier/Documents/desy/dev/gitlab.desy.de/asapo/asapo/producer/api/cpp/include -I/home/marc-olivier/Documents/desy/dev/gitlab.desy.de/asapo/asapo/producer/api/cpp/../c/include -I/home/marc-olivier/Documents/desy/dev/gitlab.desy.de/asapo/asapo/common/cpp/include -g -O0 --coverage -fprofile-arcs -ftest-coverage -Wall -Wextra -pedantic -Wconversion -Wno-missing-field-initializers -fPIC -DGTEST_HAS_PTHREAD=1 -std=gnu++11 -MD -MT producer/api/cpp/CMakeFiles/test-asapo-producer.dir/unittests/test_producer_impl.cpp.o -MF producer/api/cpp/CMakeFiles/test-asapo-producer.dir/unittests/test_producer_impl.cpp.o.d -o producer/api/cpp/CMakeFiles/test-asapo-producer.dir/unittests/test_producer_impl.cpp.o -c /home/marc-olivier/Documents/desy/dev/gitlab.desy.de/asapo/asapo/producer/api/cpp/unittests/test_producer_impl.cpp
      In file included from /home/marc-olivier/Documents/desy/dev/gitlab.desy.de/asapo/asapo/producer/api/cpp/unittests/test_producer_impl.cpp:15:
      /home/marc-olivier/Documents/desy/dev/gitlab.desy.de/asapo/asapo/producer/api/cpp/unittests/mocking.h:20:14: error: ‘uint64_t asapo::MockDiscoveryService::UpdateFrequency()’ marked ‘override’, but does not override
         20 |     uint64_t UpdateFrequency() override {
            |              ^~~~~~~~~~~~~~~
      ```
      6cc7eb6f
    • Marc-Olivier Andrez's avatar
      style: ensure that files terminate with empty new line using `pre-commit` · 58c48bd3
      Marc-Olivier Andrez authored
      As mentioned on
      https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline
      and
      https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206,
      POSIX defines a line as
      
      > A sequence of zero or more non- <newline> characters plus a terminating <newline>
      > character.
      
      When a file does not terminate with an empty line, `Git` commands such
      as `git diff` show the message `No newline at end of file`.
      
      This commit adds a CI job `pre-commit` to enforce the formatting.
      58c48bd3
  5. May 21, 2024
  6. Dec 01, 2023
  7. Nov 23, 2022
  8. Sep 09, 2022
  9. Mar 18, 2022
  10. Feb 23, 2022
  11. Feb 17, 2022
  12. Feb 16, 2022
  13. Jan 27, 2022
  14. Jan 25, 2022
  15. Jan 24, 2022
  16. Jan 21, 2022
  17. Jan 04, 2022
  18. Dec 11, 2021
  19. Dec 06, 2021
  20. Dec 04, 2021
  21. Dec 03, 2021
  22. Nov 09, 2021
  23. Oct 20, 2021
  24. Sep 28, 2021
  25. Aug 04, 2021
  26. Jul 16, 2021
  27. Jul 15, 2021
  28. Jul 09, 2021
  29. Jul 08, 2021
  30. Jul 07, 2021
  31. Jul 06, 2021
  32. Jul 01, 2021
  33. Jun 30, 2021
Loading