fix mem leaks

common/cpp/src/http_client/curl_http_client.cpp

@@ -108,7 +108,6 @@ CurlHttpClient::~CurlHttpClient() {
     if (curl_) {
         curl_easy_cleanup(curl_);
     }
-
 }
 
 

common/cpp/src/system_io/system_io_linux.cpp

@@ -202,7 +202,7 @@ void SystemIO::CollectFileInformationRecursively(const std::string& path,
 
 void SystemIO::ApplyNetworkOptions(SocketDescriptor socket_fd, Error* err) const {
     //TODO: Need to change network layer code, so everything can be NonBlocking
-    int flag;
+    int flag = 1;
     if (
         /*(flags = fcntl(socket_fd, F_GETFL, 0)) == -1
         ||

receiver/src/receiver_statistics.h

@@ -10,7 +10,6 @@ enum StatisticEntity : int {
     kDatabase = 0,
     kDisk,
     kNetwork,
-    kAuthorizer
 };
 
 static const std::vector<std::string> kStatisticEntityNames = {"db_share", "disk_share", "network_share"};

receiver/src/request_handler_authorize.cpp

@@ -100,7 +100,7 @@ RequestHandlerAuthorize::RequestHandlerAuthorize(): log__{GetDefaultReceiverLogg
 }
 
 StatisticEntity RequestHandlerAuthorize::GetStatisticEntity() const {
-    return StatisticEntity::kAuthorizer;
+    return StatisticEntity::kNetwork;
 }
 
 

receiver/src/requests_dispatcher.cpp

@@ -32,6 +32,7 @@ Error RequestsDispatcher::ProcessRequest(const std::unique_ptr<Request>& request
     Error handle_err;
     handle_err = request->Handle(statistics__);
     GenericNetworkResponse generic_response;
+    generic_response.op_code = request->GetOpCode();
     generic_response.error_code = GetNetworkCodeFromError(handle_err);
     strcpy(generic_response.message, "");
     if (handle_err) {

receiver/src/statistics.cpp

@@ -55,7 +55,7 @@ void Statistics::IncreaseRequestCounter() noexcept {
 
 Statistics::Statistics(unsigned int write_frequency) :
     write_interval_{write_frequency} {
-    statistics_sender_list__.emplace_back(new StatisticsSenderInfluxDb);
+    statistics_sender_list__.emplace_back(std::unique_ptr<StatisticsSender> {new StatisticsSenderInfluxDb});
 //    statistics_sender_list__.emplace_back(new StatisticsSenderFluentd);
     ResetStatistics();
 }

receiver/src/statistics.h

@@ -33,6 +33,7 @@ class Statistics {
     VIRTUAL void AddTag(const std::string& name, const std::string& value) noexcept;
     void SetWriteInterval(uint64_t interval_ms);
     std::vector<std::unique_ptr<StatisticsSender>> statistics_sender_list__;
+    virtual ~Statistics() = default;
   protected:
     static const unsigned int kDefaultStatisticWriteIntervalMs = 10000;
     virtual StatisticsToSend PrepareStatisticsToSend() const noexcept;

receiver/src/statistics_sender_influx_db.h

@@ -13,6 +13,9 @@ class StatisticsSenderInfluxDb : public StatisticsSender {
     virtual void SendStatistics(const StatisticsToSend& statistic) const noexcept override;
     std::unique_ptr<HttpClient> httpclient__;
     const AbstractLogger* log__;
+    ~StatisticsSenderInfluxDb() {
+        printf("Deleting StatisticsSenderInfluxDb\n");
+    };
   private:
     std::string StatisticsToString(const StatisticsToSend& statistic) const noexcept;
 

receiver/unittests/test_request_handler_authorizer.cpp

@@ -148,7 +148,7 @@ class AuthorizerHandlerTests : public Test {
 
 TEST_F(AuthorizerHandlerTests, CheckStatisticEntity) {
     auto entity = handler.GetStatisticEntity();
-    ASSERT_THAT(entity, Eq(asapo::StatisticEntity::kAuthorizer));
+    ASSERT_THAT(entity, Eq(asapo::StatisticEntity::kNetwork));
 }
 
 TEST_F(AuthorizerHandlerTests, ErrorNotAuthorizedYet) {

tests/automatic/producer_receiver/transfer_single_file/check_linux.sh

@@ -36,5 +36,4 @@ $1 localhost:8400 ${beamtime_id} 100 1 1  0 30
 
 ls -ln ${receiver_folder}/1 | awk '{ print $5 }'| grep 100000
 
-
-$1 localhost:8400 wrong_beamtime_id 100 1 1 0 1 2>1 | grep "authorization failed"
+$1 localhost:8400 wrong_beamtime_id 100 1 1 0 1 2>&1 | tee /dev/stderr | grep "authorization failed"