improve go code coverage

broker/src/asapo_broker/server/get_meta_test.go

+package server
+
+import (
+	"asapo_broker/database"
+	"asapo_common/logger"
+	"github.com/stretchr/testify/mock"
+	"github.com/stretchr/testify/suite"
+	"net/http"
+	"testing"
+)
+
+type GetMetaTestSuite struct {
+	suite.Suite
+	mock_db *database.MockedDatabase
+}
+
+func (suite *GetMetaTestSuite) SetupTest() {
+	statistics.Reset()
+	suite.mock_db = new(database.MockedDatabase)
+	db = suite.mock_db
+	prepareTestAuth()
+	logger.SetMockLog()
+}
+
+func (suite *GetMetaTestSuite) TearDownTest() {
+	assertExpectations(suite.T(), suite.mock_db)
+	logger.UnsetMockLog()
+	db = nil
+}
+
+func TestGetMetaTestSuite(t *testing.T) {
+	suite.Run(t, new(GetMetaTestSuite))
+}
+
+func (suite *GetMetaTestSuite) TestGetMetaOK() {
+	suite.mock_db.On("ProcessRequest", database.Request{DbName: expectedDBName, DbCollectionName: expectedSubstream, Op: "meta", ExtraParam: "1"}).Return([]byte(""), nil)
+	logger.MockLog.On("Debug", mock.MatchedBy(containsMatcher("processing request meta")))
+	w := doRequest("/database/" + expectedBeamtimeId + "/" + expectedStream + "/" + expectedSubstream + "/0/meta"  + "/1" + correctTokenSuffix,"GET")
+	suite.Equal(http.StatusOK, w.Code, "meta OK")
+}
+

broker/src/asapo_broker/server/post_op_image_test.go

@@ -39,3 +39,16 @@ func (suite *ImageOpTestSuite) TestAckImageOpOK() {
 	w := doRequest("/database/" + expectedBeamtimeId + "/" + expectedStream + "/" + expectedSubstream + "/" + expectedGroupID + "/1" + correctTokenSuffix,"POST",query_str)
 	suite.Equal(http.StatusOK, w.Code, "ackimage OK")
 }
+
+
+func (suite *ImageOpTestSuite) TestAckImageOpErrorWrongOp() {
+	query_str := "\"Id\":1,\"Op\":\"ackimage\"}"
+	w := doRequest("/database/" + expectedBeamtimeId + "/" + expectedStream + "/" + expectedSubstream + "/" + expectedGroupID + "/1" + correctTokenSuffix,"POST",query_str)
+	suite.Equal(http.StatusBadRequest, w.Code, "ackimage wrong")
+}
+
+func (suite *ImageOpTestSuite) TestAckImageOpErrorWrongID() {
+	query_str := "{\"Id\":1,\"Op\":\"ackimage\"}"
+	w := doRequest("/database/" + expectedBeamtimeId + "/" + expectedStream + "/" + expectedSubstream + "/" + expectedGroupID + "/bla" + correctTokenSuffix,"POST",query_str)
+	suite.Equal(http.StatusBadRequest, w.Code, "ackimage wrong")
+}

broker/src/asapo_broker/server/post_query_images_test.go

@@ -41,3 +41,4 @@ func (suite *QueryTestSuite) TestQueryOK() {
 	w := doRequest("/database/"+expectedBeamtimeId+"/"+expectedStream+"/"+expectedSubstream+"/0/queryimages"+correctTokenSuffix, "POST", query_str)
 	suite.Equal(http.StatusOK, w.Code, "Query OK")
 }
+

broker/src/asapo_broker/server/server_test.go

@@ -117,6 +117,13 @@ func TestReconnectDB(t *testing.T) {
 	db = nil
 }
 
+func TestErrorWhenReconnectNotConnectedDB(t *testing.T) {
+	err := ReconnectDb()
+	assert.NotNil(t, err, "error reconnect")
+	db = nil
+}
+
+
 func TestCleanupDBWithoutInit(t *testing.T) {
 	mock_db := setup()
 

broker/src/asapo_broker/server/statistics.go

@@ -4,7 +4,6 @@ import (
 	log "asapo_common/logger"
 	"fmt"
 	"sync"
-	"time"
 )
 
 type statisticsWriter interface {
@@ -54,14 +53,3 @@ func (st *serverStatistics) WriteStatistic() (err error) {
 	}()
 	return st.Writer.Write(st)
 }
-
-func (st *serverStatistics) Monitor() {
-	for {
-		time.Sleep(1000 * time.Millisecond)
-		if err := st.WriteStatistic(); err != nil {
-		    logstr := "sending statistics to " + settings.PerformanceDbServer + ", dbname: " + settings.PerformanceDbName
-			log.Error(logstr + " - " + err.Error())
-		}
-		st.Reset()
-	}
-}

broker/src/asapo_broker/server/statistics_nottested.go

+//+build !test
+
+package server
+
+import (
+	log "asapo_common/logger"
+	"time"
+)
+
+func (st *serverStatistics) Monitor() {
+	for {
+		time.Sleep(1000 * time.Millisecond)
+		if err := st.WriteStatistic(); err != nil {
+		    logstr := "sending statistics to " + settings.PerformanceDbServer + ", dbname: " + settings.PerformanceDbName
+			log.Error(logstr + " - " + err.Error())
+		}
+		st.Reset()
+	}
+}

broker/src/asapo_broker/server/statistics_test.go

 package server
 
 import (
+	"errors"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/mock"
 	"testing"
@@ -28,17 +29,37 @@ func assertMockWriterExpectations(t *testing.T, mock_writer *mockWriter) {
 func TestWriteStatisticsOK(t *testing.T) {
 	mock_writer := new(mockWriter)
 	statistics.Writer = mock_writer
-	statistics.Reset()
-	statistics.IncreaseCounter()
 
+	mock_writer.On("Init").Return(nil)
 	mock_writer.On("Write", &statistics).Return(nil)
 
+	statistics.Init()
+	statistics.Reset()
+	statistics.IncreaseCounter()
+    counter := statistics.GetCounter()
+
 	err := statistics.WriteStatistic()
 	assert.Nil(t, err, "Statistics written")
+	assert.Equal(t, 1, counter, "counter")
+
+	assertMockWriterExpectations(t, mock_writer)
+}
+
+func TestInitError(t *testing.T) {
+	mock_writer := new(mockWriter)
+	statistics.Writer = mock_writer
+
+	mock_writer.On("Init").Return(errors.New("error"))
+
+	statistics.Init()
+
+	err := statistics.WriteStatistic()
+	assert.NotNil(t, err, "Statistics init error")
 
 	assertMockWriterExpectations(t, mock_writer)
 }
 
+
 func TestWriteStatisticsCatchesError(t *testing.T) {
 	statistics.Writer = nil