Bibae correct
Integrated BIBAE into existing framework, currently still with faked angle (as for GAN)
Merge request reports
Activity
requested review from @thomas.madlener
- Resolved by Peter McKeown
- Resolved by Peter McKeown
- Resolved by Peter McKeown
- Resolved by Peter McKeown
381 382 ml_barrel_symmetry = 12 382 383 ml_endcap_name = 'ECalEndcap' 383 384 385 if BIBAE == True: 386 ml_file = "../models/BIBAE_Full_PP_cut.pt" 387 ml_model = "RegularGridBIBAEPolyhedraBarrelTorchModel/BarrelModelTorch" 388 ml_model_1 = "RegularGridBIBAEEndcapTorchModel/EndcapModelTorch" 389 else: 390 ml_file = "../models/francisca_gan_jit.pt" 391 ml_model = "RegularGridGANPolyhedraBarrelTorchModel/BarrelModelTorch" 392 ml_model_1 = "RegularGridGANEndcapTorchModel/EndcapModelTorch" 393 - Comment on lines +385 to +393
This will become unmaintainable once there are several models. We will cross the bridge when we need to, but this would either have to become a dictionary, or preferably a config file that is read. However, we need to establish first that the models really can all be treated the same way here.
- Resolved by Peter McKeown
- Resolved by Peter McKeown
- Resolved by Peter McKeown
- Resolved by Peter McKeown
- Resolved by Peter McKeown
- Resolved by Peter McKeown
- Resolved by Peter McKeown
- Resolved by Peter McKeown
- Resolved by Peter McKeown
- Resolved by Peter McKeown
- Resolved by Peter McKeown
Please register or sign in to reply