Skip to content
Snippets Groups Projects
  1. Aug 14, 2012
  2. Aug 13, 2012
  3. Aug 08, 2012
  4. Aug 07, 2012
  5. Aug 06, 2012
  6. Aug 03, 2012
    • Steven Murray's avatar
      bug #96536: rmlabelinfo() of tape/initlabel.c corrupts memory if called more than once · ef1d4565
      Steven Murray authored
      Added the unit-test class Ctape_reserveTest correctly this time (ismple forgot
      to add it last time).
      
      Ctape_reserve function now passes the unit-tests by return -1 and setting serrno
      to EINVAL when more than one drive is requested within a drive reservation
      request.
      ef1d4565
    • Steven Murray's avatar
      bug #96536: rmlabelinfo() of tape/initlabel.c corrupts memory if called more than once · a257ebcd
      Steven Murray authored
      The ability to reserve drives from many DGNS was blocked by the previous
      commit modifying the initlabelroutines() (SVN revision 24307).  This commit
      adds the following two unit tests:
      
       Ctape_reserveTest::testCtape_reserveWithCountOf2
       Ctape_reserveTest::testCtape_reserveWith1DgnReservationWithDriveCountOf2
      
      These two tests currently fail (test driven development). The first is a repeat
      of trying to reserve drives from more than one DGN, though this time via a
      different function Ctape_reservei().  The second and more important test is for
      the case of using Ctape_reserve to try and reserve many drives from a single DGN.
      In order to pass the unit-tests the Ctape_reserve() function needs to be
      modified to return -1 and set serrno to EINVAL if either a DGN or a drive count
      is anything other than 1.
      a257ebcd
    • Steven Murray's avatar
      bug #96536: rmlabelinfo() of tape/initlabel.c corrupts memory if called more than once · d3deba6a
      Steven Murray authored
      The unit test now passes so any rtcpd installation built now will enforce single
      dgn reservations.  In theory a program can still ask for many drives from the
      same dgn.  To be continued..
      d3deba6a
    • Steven Murray's avatar
      bug #96536: rmlabelinfo() of tape/initlabel.c corrupts memory if called more than once · 383fc4d5
      Steven Murray authored
      rmlabelinfo() assumes we support multi-drive reservations and contains buggy
      memory managment to deal with these cases.  Such reservations are no longer used
      therefore the buggy code can be removed.
      
      This commit adds a unit test which fails (test driven development) because the
      future implementation of initlabelroutines() should only accept 1 as a parameter.
      initlabelroutines() is the creator of the C structures that rmlabelinfo() tries
      to remove.
      383fc4d5
  7. Aug 02, 2012
Loading