Skip to content
Snippets Groups Projects
  1. Jul 25, 2017
  2. Nov 30, 2016
  3. Oct 11, 2016
  4. Sep 16, 2016
  5. Aug 29, 2016
  6. Feb 11, 2016
  7. Feb 03, 2016
  8. Jan 21, 2016
  9. Jul 24, 2015
  10. Jul 16, 2015
  11. Jul 15, 2015
  12. Mar 18, 2015
  13. Aug 15, 2014
  14. Aug 06, 2014
    • Steven Murray's avatar
    • Steven Murray's avatar
      Added inheritance between ZmqSocket , ZmqSocketST and ZmqSocketMT · b6edd0c0
      Steven Murray authored
      In a previous commit I removed the inheritance relationship between
      ZmqSocket and ZmqSocketMT.  I used templated functions in order to
      be able to handle instances of ZmqSocket and ZmqSocketMT with thei
      same code.  I now believe that decision was wrong in the long run.
      Future code maintainers will not know that a ZmqSocketMT object is
      a type of ZmqSocket.  Eclipse and doxygen are very good at
      providing class hierarchies.  One should benefit from this when one
      can as it is a form of free documentation.
      
      My previous commit not only removed inheritance, it also allowed
      the multi-threaded version of ZMQSocket to contain the single
      threaded version as opposed to inherit from it.  Using composition
      over inheritance prevented future mistakes where somebody adds a
      new thread-unsafe method to the super class and forgets or doesn’t
      know that they should implement a thread-safe overriding version in
      the sub-class.  This commit preserves composition over inheritance.
      
      There are now three “ZmqSocket” classes: ZmqSocket, ZmqSocketST and
      ZmqSocketMT.  ZmqSocket itself is now abstract and simply defines
      the methods such a socket should implement.  ZmqSocketST is ai
      concrete class for single-threaded use (hence ST) and
      ZmqSocketMT is for multithreaded use (hence MT).
      
      ZmqSocketST inherits from ZmqSocket and  ZmqSocketMT also inherits
      from ZmqSocket.  ZmqSocketMT does not inherit from ZmqSocketST.
      ZmqSocketMT contains an instance of ZmqSocketST therefore preserving
      the composition over inheritance solution of the previous commit.
      b6edd0c0
  15. Aug 05, 2014
  16. Aug 04, 2014
  17. Jul 31, 2014
  18. Jul 04, 2014
  19. Jul 03, 2014
  20. Jun 28, 2014
  21. Jun 26, 2014
  22. Jun 25, 2014
  23. Jun 24, 2014
  24. Jun 23, 2014
  25. Apr 23, 2014
  26. Apr 11, 2014
  27. Apr 08, 2014
  28. Apr 03, 2014
Loading