Resolve "fix STALE message when cta-taped is restarting"

ReleaseNotes.md

@@ -14,6 +14,7 @@
 - cta/CTA#1059 - Clean up warnings reported by static analysis
 - cta/CTA#1062 - cta-admin tf rm should store the diskFilePath when deleting the tape file copy
 - cta/CTA#1073 - Retry failed reporting for archive jobs
+- cta/CTA#1078 - fix STALE message when cta-taped is restarting
 
 # v4.3-3
 

scheduler/TapeDrivesCatalogueState.cpp

@@ -619,7 +619,7 @@ common::dataStructures::TapeDrive TapeDrivesCatalogueState::setTapeDriveStatus(
   const common::dataStructures::DesiredDriveState & desiredState, const common::dataStructures::MountType& type,
   const common::dataStructures::DriveStatus& status, const tape::daemon::TpconfigLine& tpConfigLine,
   const common::dataStructures::SecurityIdentity& identity) {
-  const time_t reportTime = time(NULL);
+  const time_t reportTime = time(nullptr);
   common::dataStructures::TapeDrive tapeDriveStatus;
   tapeDriveStatus.driveName = driveInfo.driveName;
   tapeDriveStatus.host = driveInfo.host;
@@ -636,8 +636,14 @@ common::dataStructures::TapeDrive TapeDrivesCatalogueState::setTapeDriveStatus(
   tapeDriveStatus.reservedBytes = 0;
   tapeDriveStatus.devFileName = tpConfigLine.devFilename;
   tapeDriveStatus.rawLibrarySlot = tpConfigLine.rawLibrarySlot;
-  tapeDriveStatus.creationLog = common::dataStructures::EntryLog(identity.username, identity.host, reportTime);
-  tapeDriveStatus.lastModificationLog = common::dataStructures::EntryLog(identity.username, identity.host, reportTime);
+  if (identity.username.empty()) {
+    tapeDriveStatus.creationLog = common::dataStructures::EntryLog("NO_USER", driveInfo.host, reportTime);
+    tapeDriveStatus.lastModificationLog = common::dataStructures::EntryLog("NO_USER", driveInfo.host, reportTime);
+  } else {
+    tapeDriveStatus.creationLog = common::dataStructures::EntryLog(identity.username, identity.host, reportTime);
+    tapeDriveStatus.lastModificationLog = common::dataStructures::EntryLog(identity.username, identity.host,
+      reportTime);
+  }
   return tapeDriveStatus;
 }
 

xroot_plugins/XrdCtaDriveLs.hpp

@@ -127,7 +127,7 @@ int DriveLsStream::fillBuffer(XrdSsiPb::OStreamBuffer<Data> *streambuf) {
     else
       dr_item->set_latest_bandwidth(0);
     dr_item->set_session_id(dr.sessionId ? dr.sessionId.value() : 0);
-    const auto lastUpdateTime = dr.lastModificationLog ? dr.lastModificationLog.value().time : 0;
+    const auto lastUpdateTime = dr.lastModificationLog ? dr.lastModificationLog.value().time : time(nullptr);
     dr_item->set_time_since_last_update(time(nullptr) - lastUpdateTime);
     dr_item->set_current_priority(dr.currentPriority ? dr.currentPriority.value() : 0);
     dr_item->set_current_activity(dr.currentActivity ? dr.currentActivity.value() : "");