Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
cta
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container registry
Harbor Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
dCache
cta
Commits
aae15da3
Commit
aae15da3
authored
6 years ago
by
Steven Murray
Browse files
Options
Downloads
Patches
Plain Diff
Removed dependencies between cta-tape-developer-acs-tools and cta::exception::DismountFailed
parent
b99d1496
Branches
Branches containing commit
Tags
Tags containing commit
No related merge requests found
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
mediachanger/acs/AcsDismountCmd.cpp
+7
-7
7 additions, 7 deletions
mediachanger/acs/AcsDismountCmd.cpp
mediachanger/acs/AcsDismountCmd.hpp
+1
-3
1 addition, 3 deletions
mediachanger/acs/AcsDismountCmd.hpp
mediachanger/acs/CMakeLists.txt
+0
-1
0 additions, 1 deletion
mediachanger/acs/CMakeLists.txt
with
8 additions
and
11 deletions
mediachanger/acs/AcsDismountCmd.cpp
+
7
−
7
View file @
aae15da3
...
...
@@ -83,11 +83,11 @@ void cta::mediachanger::acs::AcsDismountCmd::syncDismount() {
requestResponsesUntilFinal
(
requestSeqNumber
,
buf
,
m_cmdLine
.
queryInterval
,
m_cmdLine
.
timeout
);
processDismountResponse
(
buf
);
}
catch
(
cta
::
exception
::
Exception
&
e
x
)
{
cta
::
exception
::
DismountFailed
df
;
df
.
getMessage
()
<<
"Failed to dismount volume "
<<
m_cmdLine
.
volId
.
external_label
<<
": "
<<
e
x
.
getMessage
().
str
();
throw
df
;
}
catch
(
cta
::
exception
::
Exception
&
n
e
)
{
cta
::
exception
::
Exception
ex
;
ex
.
getMessage
()
<<
"Failed to dismount volume "
<<
m_cmdLine
.
volId
.
external_label
<<
": "
<<
n
e
.
getMessage
().
str
();
throw
ex
;
}
}
...
...
@@ -103,7 +103,7 @@ void cta::mediachanger::acs::AcsDismountCmd::sendDismountRequest(
m_cmdLine
.
libraryDriveSlot
,
m_cmdLine
.
force
);
m_dbg
<<
"Acs::dismount() returned "
<<
acs_status
(
s
)
<<
std
::
endl
;
if
(
STATUS_SUCCESS
!=
s
)
{
cta
::
exception
::
DismountFailed
ex
;
cta
::
exception
::
Exception
ex
;
ex
.
getMessage
()
<<
"Failed to send request to dismount volume "
<<
m_cmdLine
.
volId
.
external_label
<<
" from drive "
<<
m_acs
.
driveId2Str
(
m_cmdLine
.
libraryDriveSlot
)
<<
": force="
<<
...
...
@@ -120,7 +120,7 @@ void cta::mediachanger::acs::AcsDismountCmd::processDismountResponse(
const
ACS_DISMOUNT_RESPONSE
*
const
msg
=
(
ACS_DISMOUNT_RESPONSE
*
)
buf
;
if
(
STATUS_SUCCESS
!=
msg
->
dismount_status
)
{
cta
::
exception
::
DismountFailed
ex
;
cta
::
exception
::
Exception
ex
;
ex
.
getMessage
()
<<
"Status of dismount response is not success: "
<<
acs_status
(
msg
->
dismount_status
);
throw
ex
;
...
...
This diff is collapsed.
Click to expand it.
mediachanger/acs/AcsDismountCmd.hpp
+
1
−
3
View file @
aae15da3
...
...
@@ -20,7 +20,6 @@
#include
"AcsCmd.hpp"
#include
"AcsDismountCmdLine.hpp"
#include
"common/exception/DismountFailed.hpp"
#include
"common/exception/MissingOperand.hpp"
namespace
cta
{
...
...
@@ -84,8 +83,7 @@ protected:
void
sendDismountRequest
(
const
SEQ_NO
seqNumber
);
/**
* Throws cta::exception::DismountFailed if the mount was not
* successful.
* Process dismount response.
*
* @param buf The mount-response message.
*/
...
...
This diff is collapsed.
Click to expand it.
mediachanger/acs/CMakeLists.txt
+
0
−
1
View file @
aae15da3
...
...
@@ -70,7 +70,6 @@ install(TARGETS ctamediachangeracsunittests DESTINATION usr/${CMAKE_INSTALL_LIBD
message
(
STATUS
"Adding cta-acs-dismount target"
)
set
(
ACS_DISMOUNT_SRC_FILES
../../common/exception/Backtrace.cpp
../../common/exception/DismountFailed.cpp
../../common/exception/Exception.cpp
../../common/exception/Mismatch.cpp
../../common/exception/MissingOperand.cpp
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment