insert_with_bindUint64_2_pow_64_minus_1 now works for mysql and the 'BIGINT UNSIGNED' datatype

rdbms/StmtTest.cpp

@@ -76,6 +76,7 @@ std::string cta_rdbms_StmtTest::getCreateStmtTestTableSql() {
     case Login::DBTYPE_SQLITE:
       break;
     case Login::DBTYPE_MYSQL:
+      utils::searchAndReplace(sql, "NUMERIC(20, 0)", "BIGINT UNSIGNED");
       break;
     case Login::DBTYPE_POSTGRESQL:
       break;
@@ -189,55 +190,9 @@ TEST_P(cta_rdbms_StmtTest, insert_with_bindUint64) {
   }
 }
 
-TEST_P(cta_rdbms_StmtTest, insert_with_bindUint64_2_pow_54_minus_2) {
+TEST_P(cta_rdbms_StmtTest, insert_with_bindUint64_2_pow_64_minus_1) {
   using namespace cta::rdbms;
 
-  // The MySql support in CTA cannot store an unsigned integer greater than
-  // 2^54-2
-  const uint64_t insertValue = 18014398509481982;
-
-  // Insert a row into the test table
-  {
-    const char *const sql =
-      "INSERT INTO STMT_TEST("
-        "UINT64_COL) "
-      "VALUES("
-        ":UINT64_COL)";
-    auto stmt = m_conn.createStmt(sql);
-    stmt.bindUint64(":UINT64_COL", insertValue);
-    stmt.executeNonQuery();
-  }
-
-  // Select the row back from the table
-  {
-    const char *const sql =
-      "SELECT "
-        "UINT64_COL AS UINT64_COL "
-      "FROM "
-        "STMT_TEST";
-    auto stmt = m_conn.createStmt(sql);
-    auto rset = stmt.executeQuery();
-    ASSERT_TRUE(rset.next());
-
-    const auto selectValue = rset.columnOptionalUint64("UINT64_COL");
-
-    ASSERT_TRUE((bool)selectValue);
-
-    ASSERT_EQ(insertValue,selectValue.value());
-
-    ASSERT_FALSE(rset.next());
-  }
-}
-
-TEST_P(cta_rdbms_StmtTest, insert_with_bindUint64_2_pow_64_minus_1_not_mysql) {
-  using namespace cta::rdbms;
-
-  if(m_login.dbType == Login::DBTYPE_MYSQL) {
-    return;
-  }
-
-  // The MySql support in CTA cannot store an unsigned integer greater than
-  // 2^54-2
   const uint64_t insertValue = 18446744073709551615U;
 
   // Insert a row into the test table