Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
cta
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container Registry
Harbor Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Admin message
Today at 12:05 p.m. CEST
GitLab will be temporarily unavailable due to brief maintenance.
Show more breadcrumbs
dCache
cta
Commits
6380051e
Commit
6380051e
authored
9 years ago
by
Eric Cano
Browse files
Options
Downloads
Patches
Plain Diff
Added caching for information from archive job for logging after the object is potentially deleted.
parent
0c807e60
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
tapeserver/castor/tape/tapeserver/daemon/DiskReadTask.cpp
+6
-3
6 additions, 3 deletions
tapeserver/castor/tape/tapeserver/daemon/DiskReadTask.cpp
tapeserver/castor/tape/tapeserver/daemon/DiskReadTask.hpp
+10
-0
10 additions, 0 deletions
tapeserver/castor/tape/tapeserver/daemon/DiskReadTask.hpp
with
16 additions
and
3 deletions
tapeserver/castor/tape/tapeserver/daemon/DiskReadTask.cpp
+
6
−
3
View file @
6380051e
...
...
@@ -39,7 +39,10 @@ DiskReadTask::DiskReadTask(DataConsumer & destination,
size_t
numberOfBlock
,
castor
::
server
::
AtomicFlag
&
errorFlag
)
:
m_nextTask
(
destination
),
m_archiveJob
(
archiveJob
),
m_numberOfBlock
(
numberOfBlock
),
m_errorFlag
(
errorFlag
)
{}
{
m_archiveJobCachedInfo
.
remotePath
=
m_archiveJob
->
remotePathAndStatus
.
path
.
getRaw
();
m_archiveJobCachedInfo
.
fileId
=
m_archiveJob
->
archiveFile
.
fileId
;
}
//------------------------------------------------------------------------------
// DiskReadTask::execute
...
...
@@ -208,8 +211,8 @@ void DiskReadTask::logWithStat(int level,const std::string& msg,log::LogContext&
m_stats
.
transferTime
?
1.0
*
m_stats
.
dataVolume
/
1000
/
1000
/
m_stats
.
transferTime
:
0
)
.
add
(
"openRWCloseToTransferTimeRatio"
,
m_stats
.
transferTime
?
(
m_stats
.
openingTime
+
m_stats
.
readWriteTime
+
m_stats
.
closingTime
)
/
m_stats
.
transferTime
:
0.0
)
.
add
(
"FILEID"
,
m_archiveJob
->
archiveFile
.
fileId
)
.
add
(
"path"
,
m_archiveJob
->
remotePathAndStatus
.
path
.
getRaw
()
);
.
add
(
"FILEID"
,
m_archiveJob
CachedInfo
.
fileId
)
.
add
(
"path"
,
m_archiveJob
CachedInfo
.
remotePath
);
lc
.
log
(
level
,
msg
);
}
...
...
This diff is collapsed.
Click to expand it.
tapeserver/castor/tape/tapeserver/daemon/DiskReadTask.hpp
+
10
−
0
View file @
6380051e
...
...
@@ -97,6 +97,16 @@ private:
*/
cta
::
ArchiveJob
*
m_archiveJob
;
/**
* Information about the archive job we will cache as it is needed
* after the archive job is going to be potentially deleted by the
* writer
*/
struct
{
std
::
string
remotePath
;
uint64_t
fileId
;
}
m_archiveJobCachedInfo
;
/**
* The number of memory block we will need to read the whole file
*/
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment