#533: Fixed missing cleanup in unit tests.

Disk systems were not cleaned up from catalogue in system tests. This led to failure of tests against a persistent DB.

Also created a script to easily run the postgresql-backed DB unit tests outside of CI.

catalogue/CatalogueTest.cpp

@@ -175,6 +175,12 @@ void cta_catalogue_CatalogueTest::SetUp() {
         m_catalogue->deleteMountPolicy(mountPolicy.name);
       }
     }
+    {
+      const auto diskSystems = m_catalogue->getAllDiskSystems();
+      for(auto &ds: diskSystems) {
+        m_catalogue->deleteDiskSystem(ds.name);
+      }
+    }
   } catch(exception::Exception &ex) {
     throw exception::Exception(std::string(__FUNCTION__) + " failed: " + ex.getMessage().str());
   }

tests/postgresqlUnitTests.sh

+#!/bin/bash
+
+# Utility script to run postgresql tests like in CI.
+
+if ! rpm -q --quiet rh-postgresql96-postgresql-server; then
+  echo "Please install the package rh-postgresql96-postgresql-server to run this script."
+  exit 1
+fi
+
+if [[ !  ( -x ./catalogue/cta-catalogue-schema-create && -x ./tests/cta-rdbmsUnitTests ) ]]; then
+  echo "Please run this script from a build tree of CTA."
+  exit 1
+fi
+
+if [[ $(id -u) != "0" ]]; then
+  echo "Please run this script as root (sudo)."
+  exit 1;
+fi
+
+POSTGRESQL_DATA_DIR=/usr/local/cta_test_pgsql_data
+POSTGRESQL_LOG_DIR=/var/log/postgres
+echo POSTGRESQL_DATA_DIR=${POSTGRESQL_DATA_DIR}
+echo POSTGRESQL_LOG_DIR=${POSTGRESQL_LOG_DIR}
+mkdir -p ${POSTGRESQL_DATA_DIR}
+chown -R postgres:postgres ${POSTGRESQL_DATA_DIR}
+mkdir -p ${POSTGRESQL_LOG_DIR}
+chown -R postgres:postgres ${POSTGRESQL_LOG_DIR}
+export LD_LIBRARY_PATH=/opt/rh/rh-postgresql96/root/usr/lib64
+POSTGRES_BIN=/opt/rh/rh-postgresql96/root/usr/bin
+echo POSTGRES_BIN=${POSTGRES_BIN}
+(cd / ; 
+runuser -u postgres -- ${POSTGRES_BIN}/initdb -D ${POSTGRESQL_DATA_DIR}
+runuser -u postgres -- ${POSTGRES_BIN}/pg_ctl start -w -t 10 -D ${POSTGRESQL_DATA_DIR} -l ${POSTGRESQL_LOG_DIR}/cta_test_postgres.log
+runuser -u postgres -- ${POSTGRES_BIN}/createdb cta
+runuser -u postgres -- ${POSTGRES_BIN}/createuser -E cta
+)
+CTA_CATALOGUE_CONF=`mktemp`
+echo CTA_CATALOGUE_CONF=${CTA_CATALOGUE_CONF}
+echo 'postgresql:postgresql://cta@localhost/cta' > ${CTA_CATALOGUE_CONF}
+./catalogue/cta-catalogue-schema-create ${CTA_CATALOGUE_CONF}
+./tests/cta-rdbmsUnitTests ${CTA_CATALOGUE_CONF}
+(cd / ; runuser -u postgres -- ${POSTGRES_BIN}/pg_ctl stop -D ${POSTGRESQL_DATA_DIR})
+rm -rf ${POSTGRESQL_DATA_DIR}
\ No newline at end of file