Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
cta
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container Registry
Harbor Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
dCache
cta
Commits
21da4412
Commit
21da4412
authored
2 years ago
by
Lasse Tjernaes Wardenaer
Committed by
Jorge Camarero Vera
2 years ago
Browse files
Options
Downloads
Patches
Plain Diff
Resolve "castor::tape::tapeserver::daemon::Payload not being deallocated in cta-readtp"
parent
d6d54b42
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
ReleaseNotes.md
+1
-0
1 addition, 0 deletions
ReleaseNotes.md
tapeserver/readtp/ReadtpCmd.cpp
+1
-1
1 addition, 1 deletion
tapeserver/readtp/ReadtpCmd.cpp
with
2 additions
and
1 deletion
ReleaseNotes.md
+
1
−
0
View file @
21da4412
...
...
@@ -3,6 +3,7 @@
## Summary
### Features
-
cta/CTA#250 - Trim SQL query length in catalogue DB failure reason
-
cta/CTA#301 - Switch from new to unique pointer in CtaReadTp to fix memory leak
### Bug Fixes
### Continuous Integration
...
...
This diff is collapsed.
Click to expand it.
tapeserver/readtp/ReadtpCmd.cpp
+
1
−
1
View file @
21da4412
...
...
@@ -487,7 +487,7 @@ void ReadtpCmd::readTapeFile(
const
size_t
buffer_size
=
1
*
1024
*
1024
*
1024
;
// 1Gb
size_t
read_data_size
=
0
;
// allocate one gigabyte buffer
auto
payload
=
new
castor
::
tape
::
tapeserver
::
daemon
::
Payload
(
buffer_size
);
auto
payload
=
std
::
make_unique
<
castor
::
tape
::
tapeserver
::
daemon
::
Payload
>
(
buffer_size
);
try
{
while
(
1
)
{
if
(
payload
->
remainingFreeSpace
()
<=
reader
->
getBlockSize
())
{
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment