Skip to content
Snippets Groups Projects
Unverified Commit 92307106 authored by Dietrich Rothe's avatar Dietrich Rothe Committed by GitHub
Browse files

Wip false data loss warning (#92)


* Fix false positive data loss warning.

When having more than one data member to be matched against a macro pulse number (like an IFFF) a race condition could lead to false data loss warning.
The current algorithm is only monitoring data loss of one data member.

* fix code comment

Co-authored-by: default avatarMartin Killenberg <martin.killenberg@desy.de>
parent d0c6dc19
No related branches found
No related tags found
No related merge requests found
......@@ -47,8 +47,11 @@ namespace ChimeraTK {
<< " (repeated " << _nDataLossWarnings << " times)." << std::endl;
}
}
// Tracking that data is modified is only done for the "compareTo" variable.
// If we want to detect data loss on all variables in the consistency group, we would have to track this for
// each variable separately.
_doocsSuccessfullyUpdated = false;
}
_doocsSuccessfullyUpdated = false;
return false;
}
_doocsSuccessfullyUpdated = true;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment