Jens Georg authored 1 year ago and Martin Christoph Hierholzer committed 1 year ago

* Add clang-tidy targets to project

 - add .clang-tidy file containing our settings and some configs
   according to our coding guidelines
 - add three explicit targets for calling just lint or lint-and-fix, lint-and-fix-and-commit-after-each-fix
 - add enable-able support for CMake"s "native" clang-tidy support (makes
   build super-slow)

This file was modified inside the DeviceAccess Python bindings, which
is not allowed for files that are part of project-template. This commit
attempts to rectify this situation. It is unclear though whether this
file should be really part of the project-template.

Dietrich Rothe authored 1 year ago and Dietrich Rothe committed 1 year ago

this makes sure system-installed DOOCS is overwritten
also, we need lib/x86_64_linux-gnu/pkgconfig since e.g. gul installs there

* Enable _GLIBCXX_ASSERTIONS in Debug mode

EPICS-IOC-Adapter version 02.00 is no longer usable due to overhaul of cmake scripts

problem was introduced with commit "imported targets for set_csa"

* project-template: use lib install dir defined by GNUInstallDirs

this should fix library search problems on Tumbleweed
project-template installs cmake-config files to library destination
note, individual projects also need to be changed, for installation of actual libs

This provides ChimeraTK::<project-name> as cmake imported target.
Variables <project_name>_INCLUDE_DIRS, <project_name>LIBRARY_DIRS, <project_name>_LIBRARIES, <project_name>_CXX_FLAGS, <project_name>_LINKER_FLAGS are provided for compatibility but are generated from cmake-exports where possible and cmake imported targets should be preferred.

* provide function for option array conversion
to be used with target_compile_options etc + FindPackage results, where
findPackage results are of incorrect/old format

* FindDOOCS:
 - DOOCS components as imported targets
 - clean up no longer needed tweaks
 - add timinglib as component
 - make use of log levels and respect QUIET argument

* add_dependency: fail on wrong add_dependency usage
this was unseen since it worked in most cases but in general does not
in particular was causing trouble with imports from cppext
second arg must be version number

* pkgconfig exports
 - generated from cmake-exports
 - make linker flags come before libs, order is required e.g. for --no-as-needed flag
 - remove duplicates in output

* FindGccAtomic
- do not put absolute lib path in output since it was causing trouble with yocto builds. Should be in system lib
paths anyway. Also, make GccAtomic variable output name more consistent.

This allows easier debugging as all lines can be reached. The tsan build uses
"-o1" for performance reasons.
For asan and Debug build we use "-o0", which includes this flag, and for the
release builds we want as much optimisation we can get.

The upcoming version of the config generator script package will need
more files to be copied into the build directory. This change simply
copies all files and does not rely on a particular structure.

in order to allow that documentation includes images

Copyright by some files in ApplicationCore is owned by HZDR.

ApplicationCore was hitting the limit...

Comment describes which clang-format version to use and how to get it.

Ignore files generated by CMake during configure

There are a couple of files in the CMakeFiles folder that will match the
search patterns. This is problematic during package build, since debian
builds in a subfolder of the source folder, so we hit those files and
tests fail

Enable by adding
  include(cmake/enable_code_style_check.cmake)
to the project's CMakeLists.txt

Ignore eclipse python project file.

Consolidate coverage options

 - Remove Makefile.coverage.in
 - Drop BUILD_COVERAGE_ON_DEBUG for ENABLE_COVERAGE_REPORT (defaults to
    on if included)
 - Add clean-gcda target

this is required for dcmctrl7 config