Jens Georg authored 3 years ago and Martin Christoph Hierholzer committed 2 years ago

 - Remove Makefile.coverage.in
 - Drop BUILD_COVERAGE_ON_DEBUG for ENABLE_COVERAGE_REPORT (defaults to
    on if included)
 - Add clean-gcda target

Dietrich Rothe authored 3 years ago and Martin Christoph Hierholzer committed 2 years ago

this is required for dcmctrl7 config

Jens Georg authored 3 years ago and Martin Christoph Hierholzer committed 2 years ago

This fixes issues when using LaTeX in doxygen

Previous attempt to work around the tine linking issue did not work.

This is a work around for not finding libtinemt at runtime. The DOOCS serverlib is lacking the RPATH, hence its dependencies are not found. If clientlib is linked first, tine is already linked.

Search explicitly for libgul14 which is required by DOOCS libraries

Introduce StatusWithMessage and StatusWithMessageReader which handle this.
It is used in DeviceModule error reporting.
This is a preparation in order that we can report errors consistently to DOOCS, in DoocsAdapter

make StatusAggregator use StatusWithMessage

it should output always status code + string
on the input side, connects to either status or status + string
corresponding string input is found automatically
NOTE: DeviceModule API change, the status output variables are
renamed from (status, message) to (status, status_message)!

update testing of DeviceModule outputs

because of API change of DeviceModule  (renamed message ->
status_message)

fix crash and improve message and test

- fix crash due to incorrect handling of cast to Derived
- improve message output
- make existing tests pass
- add test for status message of StatusAggregator

move StatusWithMessageReaderBase and Status def to ControlSystemAdapter

since it is required from ApplicationCore as well as from the adapters

makes test move_invalid pass

it currently fails, showing an existing problem

Co-authored-by: d-rothe <39566710+d-rothe@users.noreply.github.com>

Sometimes several long running modules in a row might have caused false alarms. So seen in tests of the llrfctrl server with multiple devices (which require some time to open and initialise).

Simply add timeout to acquiring the testable mode lock and print an error message with the last thread which successfully obtained the thread. Finally throw an exception to help debugging.

Without them, the references become invalid in move operations which leads to subsequent segfaults.

* optimization for StatusAggregator
make getPriority faster by making prio map static and reduce evaluation frequency

* get rid of compiler warning

* comment for statusPrio

Co-authored-by: Dietrich Rothe <dietrich.rothe@desy.de>

Slashes are not allowed in module names, but the DeviceModule crates a status module using the CDD (or alias) as a name. The slashes are now replaced by underscores.

ApplicationCore 02.07 is the planned feature upgrade (PreriodicTrigger) for DeviceAccess 02.08, while the master already is on DeviceAccess 03.00

Did not increase the patch because of binary incompatibilities.

See #7425

It can be static and it may make sense to use it outside modules. The implementation should probably move to a Application member function to make it easier to reach from non-module code.