Skip to content
Snippets Groups Projects
Commit a05ff486 authored by Martin Christoph Hierholzer's avatar Martin Christoph Hierholzer
Browse files

TestFacility: do not wait until device backends are open

This was a left-over from times when no proper initial value propagation
and exception handling was implemented in ApplicationCore. Waiting until
the backends are open is anyway not sufficient, since the DeviceModule
needs to finish the recovery procedure. If any test would still rely on
this (anti-)feature, it would be subject to race conditions.

The wait is removed because it prevents important tests for the
exception handling specification. In particular, tests which
intentionally break devices during startup of the application would not
be implementable.
parent 222b2b3b
No related branches found
No related tags found
No related merge requests found
......@@ -79,17 +79,6 @@ namespace ChimeraTK {
Application::getInstance().run();
// set thread name
Application::registerThread("TestThread");
// wait until all devices are opened
Application::testableModeUnlock("waitDevicesToOpen");
while(true) {
boost::this_thread::yield();
bool allOpened = true;
for(auto dm : Application::getInstance().deviceModuleMap) {
if(!dm.second->device.isOpened()) allOpened = false;
}
if(allOpened) break;
}
Application::testableModeLock("waitDevicesToOpen");
// make sure all initial values have been propagated when in testable mode
if(Application::getInstance().isTestableModeEnabled()) {
// call stepApplication() only in testable mode and only if the queues are not empty
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment