From f46d2998b01de9ff4512b5ed6b0df1a4ac93faca Mon Sep 17 00:00:00 2001
From: Sergey Yakubov <sergey.yakubov@desy.de>
Date: Mon, 24 Jun 2019 13:51:40 +0200
Subject: [PATCH] fix

---
 common/cpp/include/common/error.h                          | 4 +---
 examples/worker/getnext_broker/getnext_broker.cpp          | 6 ++++--
 .../manual/performance_broker_receiver/getlast_broker.cpp  | 4 ++--
 worker/api/cpp/include/worker/worker_error.h               | 1 +
 worker/api/cpp/src/server_data_broker.cpp                  | 7 +++----
 worker/api/cpp/unittests/test_server_broker.cpp            | 1 +
 6 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/common/cpp/include/common/error.h b/common/cpp/include/common/error.h
index ef131f3b5..397b56858 100644
--- a/common/cpp/include/common/error.h
+++ b/common/cpp/include/common/error.h
@@ -8,8 +8,7 @@
 namespace asapo {
 
 enum class ErrorType {
-    kUnknownError,
-
+    kUnknownError = 0,
     kAsapoError,
     kHttpError,
     kIOError,
@@ -19,7 +18,6 @@ enum class ErrorType {
     kWorkerError,
     kMemoryAllocationError,
     kEndOfFile,
-    kTimeOut
 };
 
 class ErrorInterface;
diff --git a/examples/worker/getnext_broker/getnext_broker.cpp b/examples/worker/getnext_broker/getnext_broker.cpp
index 7fa75a351..2e34cd098 100644
--- a/examples/worker/getnext_broker/getnext_broker.cpp
+++ b/examples/worker/getnext_broker/getnext_broker.cpp
@@ -10,6 +10,7 @@
 
 #include "asapo_worker.h"
 
+
 using std::chrono::high_resolution_clock;
 using asapo::Error;
 
@@ -35,7 +36,7 @@ void WaitThreads(std::vector<std::thread>* threads) {
 int ProcessError(const Error& err) {
     if (err == nullptr) return 0;
     std::cout << err->Explain() << std::endl;
-    return err->GetErrorType() == asapo::ErrorType::kTimeOut ? 0 : 1;
+    return err == asapo::IOErrorTemplates::kTimeout ? 0 : 1;
 }
 
 std::vector<std::thread> StartThreads(const Params& params,
@@ -80,7 +81,8 @@ std::vector<std::thread> StartThreads(const Params& params,
                 }
             } else {
                 (*errors)[i] += ProcessError(err);
-                if (err->GetErrorType() == asapo::ErrorType::kTimeOut) {
+                std::cout << "Received: " << (int)err->GetErrorType() << err << std::endl;
+                if (err == asapo::IOErrorTemplates::kTimeout) {
                     break;
                 }
             }
diff --git a/tests/manual/performance_broker_receiver/getlast_broker.cpp b/tests/manual/performance_broker_receiver/getlast_broker.cpp
index 95c374790..3a49bdc95 100644
--- a/tests/manual/performance_broker_receiver/getlast_broker.cpp
+++ b/tests/manual/performance_broker_receiver/getlast_broker.cpp
@@ -36,7 +36,7 @@ void WaitThreads(std::vector<std::thread>* threads) {
 int ProcessError(const Error& err) {
     if (err == nullptr) return 0;
     std::cout << err->Explain() << std::endl;
-    return err->GetErrorType() == asapo::ErrorType::kTimeOut ? 0 : 1;
+    return err == asapo::IOErrorTemplates::kTimeout ? 0 : 1;
 }
 
 std::vector<std::thread> StartThreads(const Params& params,
@@ -77,7 +77,7 @@ std::vector<std::thread> StartThreads(const Params& params,
                 }
             } else {
                 (*errors)[i] += ProcessError(err);
-                if (err->GetErrorType() == asapo::ErrorType::kTimeOut) {
+                if (err == asapo::IOErrorTemplates::kTimeout) {
                     break;
                 }
             }
diff --git a/worker/api/cpp/include/worker/worker_error.h b/worker/api/cpp/include/worker/worker_error.h
index e2b280a17..67839db62 100644
--- a/worker/api/cpp/include/worker/worker_error.h
+++ b/worker/api/cpp/include/worker/worker_error.h
@@ -2,6 +2,7 @@
 #define ASAPO_WORKER_ERROR_H
 
 #include "common/error.h"
+#include "common/io_error.h"
 
 namespace asapo {
 
diff --git a/worker/api/cpp/src/server_data_broker.cpp b/worker/api/cpp/src/server_data_broker.cpp
index 58185be85..6a9699b9f 100644
--- a/worker/api/cpp/src/server_data_broker.cpp
+++ b/worker/api/cpp/src/server_data_broker.cpp
@@ -1,16 +1,15 @@
 #include "server_data_broker.h"
 
 #include <chrono>
+#include <iostream>
 
 #include <json_parser/json_parser.h>
-
 #include "io/io_factory.h"
-
 #include "http_client/http_error.h"
 #include "tcp_client.h"
 
-#include <iostream>
-#include <asapo_worker.h>
+
+#include "asapo_worker.h"
 
 using std::chrono::high_resolution_clock;
 
diff --git a/worker/api/cpp/unittests/test_server_broker.cpp b/worker/api/cpp/unittests/test_server_broker.cpp
index 86854a0ec..852556296 100644
--- a/worker/api/cpp/unittests/test_server_broker.cpp
+++ b/worker/api/cpp/unittests/test_server_broker.cpp
@@ -532,6 +532,7 @@ TEST_F(ServerDataBrokerTests, QueryImagesReturnEmptyResults) {
 
 TEST_F(ServerDataBrokerTests, QueryImagesReturnRecords) {
     return;
+    
     MockGetBrokerUri();
 
     auto rec1 = CreateFI();
-- 
GitLab