From 796efa87058476422f84a68d5fad966542a37867 Mon Sep 17 00:00:00 2001 From: Sergey Yakubov <sergey.yakubov@desy.de> Date: Fri, 16 Jul 2021 12:08:55 +0200 Subject: [PATCH] fix memory leak --- .../cpp/include/asapo/common/internal/asapo_common_c_glue.h | 4 +--- tests/automatic/consumer/consumer_api/consumer_api.c | 3 +-- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/common/cpp/include/asapo/common/internal/asapo_common_c_glue.h b/common/cpp/include/asapo/common/internal/asapo_common_c_glue.h index 6d80bb1d3..69ba79ac1 100644 --- a/common/cpp/include/asapo/common/internal/asapo_common_c_glue.h +++ b/common/cpp/include/asapo/common/internal/asapo_common_c_glue.h @@ -30,9 +30,7 @@ template<> class AsapoHandlerHolder < std::string> final : public AsapoHandle { public: AsapoHandlerHolder(const std::string& handle_i) : handle{new std::string(handle_i)} {}; - ~AsapoHandlerHolder() override { - handle.release(); - } + ~AsapoHandlerHolder() override = default; std::unique_ptr<std::string> handle{nullptr}; }; //! handle for credentials to access a source from a producer diff --git a/tests/automatic/consumer/consumer_api/consumer_api.c b/tests/automatic/consumer/consumer_api/consumer_api.c index 24ac19d55..0ec099002 100644 --- a/tests/automatic/consumer/consumer_api/consumer_api.c +++ b/tests/automatic/consumer/consumer_api/consumer_api.c @@ -224,8 +224,7 @@ int main(int argc, char* argv[]) { EXIT_IF_ERROR("create consumer", err); AsapoStringHandle group_id2 = asapo_string_from_c_str("hello"); - printf("%s\n",asapo_string_c_str(group_id2)); -// ASSERT_EQ_STRING("hello",asapo_string_c_str(group_id2),"asapo str <-> string"); + ASSERT_EQ_STRING("hello",asapo_string_c_str(group_id2),"asapo str <-> string"); asapo_consumer_set_timeout(consumer, 1000ull); -- GitLab