GitLab

time to move on ...

Acked-by: Lea Morschel
Target: master

Acked-by: Paul Millar
Acked-by: Lea Morschel
Target: master

Motivation:
The nfsv4 client code is for testing purposes only. In addition it adds
an extra dependency which is not required by server part.

Modification:
move nfs4 client code into basic-client module.

Result:
reduced transient dependency and testing code from the core components.

Acked-by: Albert Rossi
Target: master

Motivation:
The use of ByteBuffer for IO operations adds more flexibility as ByteBuffers
can be sliced, shared and passed directly to various channels. Moreover, any
byte array can be easily wrapped into ByteBuffer, if needed.

Modification:
added vfs#read and vfs#write methods with default implementation falling
back to byte array based methods to maintain backward compatibility. Updated
OperationREAD and OperationWRITE to use the new methods. Deprecate byte
array based methods.

Result:
more flexibility with same functionality.

Acked-by: Paul Millar
Target: master

as there is a corresponding  InetAddresses#isInetAddress. Drop extra
methods isValidIpAddress  and isValidHostName in favor of direct calling
corresponding methods from guava library.

Acked-by: Lea Morschel
Acked-by: Paul Millar
Target: master

Motivation:
in a highly concurrent environment the ConcurrentHashMap hash map has
a better throughput than synchronized hashmap.

Benchmark                                                (map)   Mode  Cnt       Score       Error  Units
FileTrackerBenchmark.fileTrackerHashMapTest      HashMap  thrpt   25  691051.876 ± 23720.699  ops/s
FileTrackerBenchmark.fileTrackerHashMapTest  ConcHashMap  thrpt   25  792051.898 ± 18111.740  ops/s

Benchmark with 48 concurrent clients.

Modification:
Update FileTracker to use ConcurrentHashMap to track open files

Result:
better throughput in concurrent environment

Acked-by: Lea Morschel
Target: master

Acked-by: Lea Morschel
Target: master

no code changes.

CVE-2018-10237

Extract interface for client cache to allow custom implementations. S…

Extract interface for client cache to allow custom implementations. See #37 for reasons of possible other lax implementations with non expiring client leases.
Signed-off-by: David Kocher <dkocher@iterate.ch>

* Reduce number of callbacks when checking access flags.
Signed-off-by: David Kocher <dkocher@iterate.ch>

* Fix test.
Signed-off-by: David Kocher <dkocher@iterate.ch>

Expose case sensitivity settings

Signed-off-by: David Kocher <dkocher@iterate.ch>

Motivation:
stateid4 is a struct that holds a byte array and int. No need
for extra wrapper around int.

Modification:
use plain int to reduce object creation.

Result:
simpler code.

Acked-by: Paul Millar
Acked-by: Svenja Meyer
Target: master

Motivation:
as nfs-spring module expected to be used in spring based application,
we can expect spring libraries to be available at the runtime.

Modification:A
make spring dependency scope `provided`

Result:
less mess with transient dependencies for spring based apps.

Acked-by: Lea Morschel
Acked-by: Paul Millar
Target: master

Add a way to programmatically modify db configuration

Acked-by: Lea Morschel
Target: master

Motivation:
according to rfc 7862 minimal nfs v4.2 server should accept minorversion
2 requests and can respond 'not supported' to all in the spec defined
operations.

Modification:
accept minorversion 2 and respond 'not supported' to

- ALLOCATE
- COPY
- COPY_NOTIFY
- DEALLOCATE
- IO_ADVISE
- OFFLOAD_CANCEL
- OFFLOAD_STATUS
- READ_PLUS
- SEEK
- WRITE_SAME
- CLONE

Result:

'Noop' spec compliant nfs 4.2 implementation

Acked-by: Lea Morschel
Target: master

Acked-by: Albert Rossi
Acked-by: Lea Morschel
Target: master

improve protocol spec compliance.

Acked-by: Lea Morschel
Target: master, 0.20

Motivation:
user interrupt and commend quit/exit should have the same exit path.

Result:
single point to exit command loop

Acked-by: Lea Morschel
Target: master

Motivation:
improve code readability

Modification:
convert if-else chain into switch statement

Result:
easier to read and maintain (?)

Acked-by: Lea Morschel
Target: master

Motivation:
the decorator must forward all methods to avoid default behavior.

Modification:
add missing xattr related methods ForwardingFileSystem

Result:
the methods of decorated class is used instead of default behaviour.

Acked-by: Albert Rossi
Target: master, 0.20

Motivation:
from jline2 official page:
"JLine 2.x development has come to an end, and users are encouraged to
investigate the use of JLine 3.x instead."

Modification:
update pom  to use new library. adjust code to new API.

Result:
up-to-date dependency

Acked-by: Albert Rossi
Target: master

Acked-by: Paul Millar
Target: master, 0.20

Acked-by: Lea Morschel
Target: master, 0.20

Motivation:
the ACCESS4_XAREAD  ACCESS4_XAWRITE  ACCESS4_XALIST access
modes should be recognized by the server as valid values.

Modification:
add xattr access modes to the mask

Result:
server accepts xattr access masks.

Acked-by: Lea Morschel
Target: master, 0.20

Acked-by: Lea Morschel
Target: master

Acked-by: Albert Rossi
Target: master

Motivation:
if server uses another non default value for leas time, then value
returned by GETATTR is incorrect.

Modification:
introduce NFSv4StateHandler#getLeaseTime and use it to get the value of
FATTR4_LEASE_TIME attribute.

Result:
a server with non default lease time will return the correct value on
getattr.

Acked-by: Albert Rossi
Target: master

Motivation:
according to rfc7530, nfs_lease4 is 32 bit integer and expressed in
seconds. This doesn't match with current internals of NFSv4StateHandler.

Modification:
update NFSv4StateHandler to store lease time as seconds.

Result:
no visible changes. Ground work for up-coming changes.

Acked-by: Albert Rossi
Target: master

Acked-by: Paul Millar
Acked-by: Lea Morschel
Target: master