1. 26 May, 2020 1 commit
  2. 21 May, 2020 1 commit
  3. 20 May, 2020 2 commits
  4. 19 May, 2020 1 commit
    • Tigran Mkrtchyan's avatar
      nfs4: simplify stateid4 class · 59550a9c
      Tigran Mkrtchyan authored
      Motivation:
      stateid4 is a struct that holds a byte array and int. No need
      for extra wrapper around int.
      
      Modification:
      use plain int to reduce object creation.
      
      Result:
      simpler code.
      
      Acked-by: Paul Millar
      Acked-by: Svenja Meyer
      Target: master
      59550a9c
  5. 08 May, 2020 1 commit
    • Tigran Mkrtchyan's avatar
      nfs: make spring dependency scope `provided` · 3b8d58d2
      Tigran Mkrtchyan authored
      Motivation:
      as nfs-spring module expected to be used in spring based application,
      we can expect spring libraries to be available at the runtime.
      
      Modification:A
      make spring dependency scope `provided`
      
      Result:
      less mess with transient dependencies for spring based apps.
      
      Acked-by: Lea Morschel
      Acked-by: Paul Millar
      Target: master
      3b8d58d2
  6. 22 Apr, 2020 1 commit
  7. 08 Apr, 2020 2 commits
    • Tigran Mkrtchyan's avatar
      nfs42: implement minimal nfs v4.2 server · 5a36149f
      Tigran Mkrtchyan authored
      Motivation:
      according to rfc 7862 minimal nfs v4.2 server should accept minorversion
      2 requests and can respond 'not supported' to all in the spec defined
      operations.
      
      Modification:
      accept minorversion 2 and respond 'not supported' to
      
      - ALLOCATE
      - COPY
      - COPY_NOTIFY
      - DEALLOCATE
      - IO_ADVISE
      - OFFLOAD_CANCEL
      - OFFLOAD_STATUS
      - READ_PLUS
      - SEEK
      - WRITE_SAME
      - CLONE
      
      Result:
      
      'Noop' spec compliant nfs 4.2 implementation
      
      Acked-by: Lea Morschel
      Target: master
      5a36149f
    • Tigran Mkrtchyan's avatar
      nfs42: add auto-generated code of NFSv4.2 data types · 05f51790
      Tigran Mkrtchyan authored
      Acked-by: Albert Rossi
      Acked-by: Lea Morschel
      Target: master
      05f51790
  8. 06 Apr, 2020 1 commit
  9. 23 Mar, 2020 2 commits
  10. 20 Mar, 2020 2 commits
    • Tigran Mkrtchyan's avatar
      vfs: add missing xattr related methods to ForwardingFileSystem · a8c0ec1b
      Tigran Mkrtchyan authored
      Motivation:
      the decorator must forward all methods to avoid default behavior.
      
      Modification:
      add missing xattr related methods ForwardingFileSystem
      
      Result:
      the methods of decorated class is used instead of default behaviour.
      
      Acked-by: Albert Rossi
      Target: master, 0.20
      a8c0ec1b
    • Tigran Mkrtchyan's avatar
      libs: use jline3 · 95db0e59
      Tigran Mkrtchyan authored
      Motivation:
      from jline2 official page:
      "JLine 2.x development has come to an end, and users are encouraged to
      investigate the use of JLine 3.x instead."
      
      Modification:
      update pom  to use new library. adjust code to new API.
      
      Result:
      up-to-date dependency
      
      Acked-by: Albert Rossi
      Target: master
      95db0e59
  11. 16 Mar, 2020 2 commits
  12. 12 Mar, 2020 1 commit
    • Tigran Mkrtchyan's avatar
      vfs: add xattr access modes to the mask · 0b38172b
      Tigran Mkrtchyan authored
      Motivation:
      the ACCESS4_XAREAD  ACCESS4_XAWRITE  ACCESS4_XALIST access
      modes should be recognized by the server as valid values.
      
      Modification:
      add xattr access modes to the mask
      
      Result:
      server accepts xattr access masks.
      
      Acked-by: Lea Morschel
      Target: master, 0.20
      0b38172b
  13. 02 Mar, 2020 1 commit
  14. 26 Feb, 2020 3 commits
  15. 25 Feb, 2020 2 commits
    • Tigran Mkrtchyan's avatar
      nfs4: getattr should return lease time configured on state handler · 1cf016b0
      Tigran Mkrtchyan authored
      Motivation:
      if server uses another non default value for leas time, then value
      returned by GETATTR is incorrect.
      
      Modification:
      introduce NFSv4StateHandler#getLeaseTime and use it to get the value of
      FATTR4_LEASE_TIME attribute.
      
      Result:
      a server with non default lease time will return the correct value on
      getattr.
      
      Acked-by: Albert Rossi
      Target: master
      1cf016b0
    • Tigran Mkrtchyan's avatar
      nfs4: update NFSv4StateHandler to store lease time as seconds · 248c8779
      Tigran Mkrtchyan authored
      Motivation:
      according to rfc7530, nfs_lease4 is 32 bit integer and expressed in
      seconds. This doesn't match with current internals of NFSv4StateHandler.
      
      Modification:
      update NFSv4StateHandler to store lease time as seconds.
      
      Result:
      no visible changes. Ground work for up-coming changes.
      
      Acked-by: Albert Rossi
      Target: master
      248c8779
  16. 24 Feb, 2020 2 commits
    • Tigran Mkrtchyan's avatar
      mount: add missing message placeholder in log a statement · 540ec29b
      Tigran Mkrtchyan authored
      Acked-by: Paul Millar
      Acked-by: Lea Morschel
      Target: master
      540ec29b
    • Tigran Mkrtchyan's avatar
      nfs4: make extended NFSv4StateHandler constructor public · 06151918
      Tigran Mkrtchyan authored
      Motivation:
      the NFSv4StateHandler(leaseTime, instanceId, clientStore)  constructor
      can be used by NFS servers to control NFSv4StateHandler instance
      creation. As extended constructor is package protected, thus control is
      unavailable to other modules.
      
      Modification:
      make extended NFSv4StateHandler constructor public. Updated javadoc.
      
      Result:
      more control on how instance of NFSv4StateHandler created.
      
      Acked-by: Paul Millar
      Target: master
      06151918
  17. 07 Feb, 2020 1 commit
  18. 24 Jan, 2020 1 commit
    • Tigran Mkrtchyan's avatar
      src: rename org.dcache.utils => org.dcache.nfs.utils · dfbb6721
      Tigran Mkrtchyan authored
      Motivation:
      Java9 module subsystem doesn't allow different one package to exists
      in two jars files. As org.dcache.utils is too generic and exists in
      other dcache components as well, we have to avoid it's usage.
      
      Modification:
      rename org.dcache.utils package to org.dcache.nfs.util
      
      Result:
      initial step in a direction to provide Java9 compatible modules
      
      Acked-by: Lea Morschel
      Target: master
      dfbb6721
  19. 17 Dec, 2019 1 commit
    • Tigran Mkrtchyan's avatar
      pom: filter out naming related Spotbugs issues · 7e7bee6b
      Tigran Mkrtchyan authored
      Motivation:
      As nfs4j uses autogenerated code, filter out naming issues to
      make critical problems more visible.
      
      Modification:
      introduce spotbugs-exclude.xml file containing warnings that
      should be ignored.
      
      Result:
      critical problems more visible
      
      Acked-by: Paul Millar
      Acked-by: Lea Morschel
      Target: master
      7e7bee6b
  20. 13 Dec, 2019 1 commit
    • Tigran Mkrtchyan's avatar
      flexfiles: remove Serializable marker from autogenerated classes · 88180c95
      Tigran Mkrtchyan authored
      Motivation:
       - we should never serialize xdr objects
       - some classes are composites of non Serializables, thus can't be
         serialized at all
       - SpotBugs generates a warning
      
      Modification:
      remove Serializable marker from autogenerated classes
      
      Result:
      cleaner code. No visible changes.
      
      Acked-by: Olufemi Adeyemi
      Acked-by: Lea Morschel
      Target: master
      88180c95
  21. 12 Dec, 2019 1 commit
  22. 04 Dec, 2019 1 commit
  23. 03 Dec, 2019 1 commit
    • Tigran Mkrtchyan's avatar
      nfs: add initial implementation of xattr support · a1f08100
      Tigran Mkrtchyan authored
      Motivation:
      
      Modification:
      pass nfs requests to backend file system implementation. The list operation
      for now assumes that reply will fit into a single reply.
      
      Result:
      minimal support of file extended attribute over NFS
      
      Acked-by: Paul Millar
      Target: master
      a1f08100
  24. 29 Nov, 2019 1 commit
    • Tigran Mkrtchyan's avatar
      vfs: invalidate stat cache on setxattr and removexattr · 5b41bd7b
      Tigran Mkrtchyan authored
      Motivation:
      as extended attribute cache on the client side bound to regular attribute
      cache, changes of extended attributes must invalidate attribute cache to
      propagate changes to other clients.
      
      Modification:
      invalidate stat cache on setxattr and removexattr
      
      Result:
      maintain cache consistency
      
      Acked-by: Paul Millar
      Acked-by: Lea Morschel
      Target: master
      5b41bd7b
  25. 25 Nov, 2019 2 commits
    • Tigran Mkrtchyan's avatar
      nfsv4: sort constants defined in nfs4_prot.java · eedb5e65
      Tigran Mkrtchyan authored
      for better visual perception group by domains and
      order by values all constants defined in nfs4_prot.java
      
      Acked-by: Paul Millar
      Target: master
      eedb5e65
    • Tigran Mkrtchyan's avatar
      nfs4: add xattr related operation stubs · 03c7147c
      Tigran Mkrtchyan authored
      Motivation:
      Before nfs server can fully support extended attributes, the related operations
      sold be accepted by the server.
      
      Modification:
      Implement xattr related operation stubs that currently do nothing.
      
      Result:
      ground work for xattr support
      
      Acked-by: Lea Morschel
      Target: master
      03c7147c
  26. 22 Nov, 2019 2 commits
    • Tigran Mkrtchyan's avatar
      nfs4: add initial support `support_xattr` attribute · 6eaebcd9
      Tigran Mkrtchyan authored
      Motivation:
      As client might chack for support of extended attribute, let server
      nicely reply 'not supported'
      
      Modification:
      introduce FATTR4_XATTR_SUPPORT bit in bitmask of support attributes.
      Reply hard-coded 'not supported' as long as backend file system can't be
      queried for this information.
      
      Result:
      client can auto-discover (not yet) that whatever extended attributes are
      supported or not.
      
      Acked-by: Lea Morschel
      Acked-by: Paul Millar
      Target: master
      6eaebcd9
    • Tigran Mkrtchyan's avatar
      vfs: introduce get/set/list/removeXattr methods · 1c80fb61
      Tigran Mkrtchyan authored
      Motivation:
      In order NFS server to support extended attributes, they should be exposed
      by under laying vfs interface.
      
      Modification:
      introduce VirtualFileSystem#get/set/list/removeXattr methods with default
      implementations. Update PseudoFs to check permissions and bypass
      requests to backing implementation.
      
      To read or list extended attributes, read permission on the file is required
      To set or remove extended attributes, write permissions on the file is required
      
      Result:
      ground work for extended attribute support.
      
      Acked-by: Lea Morschel
      Acked-by: Paul Millar
      Target: master
      1c80fb61
  27. 19 Nov, 2019 3 commits
    • Tigran Mkrtchyan's avatar
      nfs: define error codes defined in rfc8276 (xattr) · 2b803c0d
      Tigran Mkrtchyan authored
      Motivation;
      The rfc8276 that specifies extended attribute support over NFS defines
      new error codes that should be handled by servers.
      
      Modification:
      define new error codes and add corresponding exceptions.
      
      Result:
      Ground work for xattr support.
      
      Acked-by: Paul Millar
      Acked-by: Lea Morschel
      Target: master
      2b803c0d
    • Tigran Mkrtchyan's avatar
      docs: add rfc8276.txt · fa8ebf93
      Tigran Mkrtchyan authored
      fa8ebf93
    • Tigran Mkrtchyan's avatar
      test: enforce default file permission for DummyVFS · 52d1fdfd
      Tigran Mkrtchyan authored
      Motivation:
      As we don't explicitly create fs-root object, the fs
      default value will be used as initial mode. An explicit
      value will make tests more stable and don't rely on umask
      value of the environment.
      
      Modification:
      enforce default file permission for DummyVFS
      
      Result:
      environment independent test behavior.
      
      Acked-by: Paul Millar
      Acked-by: Lea Morschel
      Target: master
      52d1fdfd