Commit 88180c95 authored by Tigran Mkrtchyan's avatar Tigran Mkrtchyan
Browse files

flexfiles: remove Serializable marker from autogenerated classes

Motivation:
 - we should never serialize xdr objects
 - some classes are composites of non Serializables, thus can't be
   serialized at all
 - SpotBugs generates a warning

Modification:
remove Serializable marker from autogenerated classes

Result:
cleaner code. No visible changes.

Acked-by: Olufemi Adeyemi
Acked-by: Lea Morschel
Target: master
parent 36724e81
......@@ -19,7 +19,7 @@ import org.dcache.nfs.v4.xdr.nfs_fh4;
import org.dcache.nfs.v4.xdr.stateid4;
import org.dcache.nfs.v4.xdr.uint32_t;
public class ff_data_server4 implements XdrAble, java.io.Serializable {
public class ff_data_server4 implements XdrAble {
public deviceid4 ffds_deviceid;
public uint32_t ffds_efficiency;
public stateid4 ffds_stateid;
......@@ -27,8 +27,6 @@ public class ff_data_server4 implements XdrAble, java.io.Serializable {
public fattr4_owner ffds_user;
public fattr4_owner_group ffds_group;
private static final long serialVersionUID = -8092922682977140250L;
public ff_data_server4() {
}
......
......@@ -14,12 +14,10 @@ import org.dcache.oncrpc4j.xdr.XdrEncodingStream;
import java.io.IOException;
import org.dcache.nfs.v4.xdr.multipath_list4;
public class ff_device_addr4 implements XdrAble, java.io.Serializable {
public class ff_device_addr4 implements XdrAble {
public multipath_list4 ffda_netaddrs;
public ff_device_versions4 [] ffda_versions;
private static final long serialVersionUID = 6386983171819598143L;
public ff_device_addr4() {
}
......
......@@ -14,15 +14,13 @@ import org.dcache.oncrpc4j.xdr.XdrEncodingStream;
import java.io.IOException;
import org.dcache.nfs.v4.xdr.uint32_t;
public class ff_device_versions4 implements XdrAble, java.io.Serializable {
public class ff_device_versions4 implements XdrAble {
public uint32_t ffdv_version;
public uint32_t ffdv_minorversion;
public uint32_t ffdv_rsize;
public uint32_t ffdv_wsize;
public boolean ffdv_tightly_coupled;
private static final long serialVersionUID = 8550127182986622481L;
public ff_device_versions4() {
}
......
......@@ -15,9 +15,7 @@ import java.io.IOException;
import org.dcache.nfs.v4.xdr.nfstime4;
import org.dcache.nfs.v4.xdr.uint64_t;
public class ff_io_latency4 implements XdrAble, java.io.Serializable {
private static final long serialVersionUID = 4758450970321975640L;
public class ff_io_latency4 implements XdrAble {
public uint64_t ffil_ops_requested;
public uint64_t ffil_bytes_requested;
......
......@@ -18,14 +18,12 @@ import org.dcache.nfs.v4.xdr.length4;
import org.dcache.nfs.v4.xdr.offset4;
import org.dcache.nfs.v4.xdr.stateid4;
public class ff_ioerr4 implements XdrAble, java.io.Serializable {
public class ff_ioerr4 implements XdrAble {
public offset4 ffie_offset;
public length4 ffie_length;
public stateid4 ffie_stateid;
public device_error4[] ffie_errors;
private static final long serialVersionUID = 616611153944851361L;
public ff_ioerr4() {
}
......
......@@ -19,7 +19,7 @@ import org.dcache.nfs.v4.xdr.length4;
import org.dcache.nfs.v4.xdr.offset4;
import org.dcache.nfs.v4.xdr.stateid4;
public class ff_iostats4 implements XdrAble, java.io.Serializable {
public class ff_iostats4 implements XdrAble {
public offset4 ffis_offset;
public length4 ffis_length;
public stateid4 ffis_stateid;
......@@ -28,8 +28,6 @@ public class ff_iostats4 implements XdrAble, java.io.Serializable {
public deviceid4 ffis_deviceid;
public ff_layoutupdate4 ffis_layoutupdate;
private static final long serialVersionUID = 1687051831434791943L;
public ff_iostats4() {
}
......
......@@ -15,14 +15,12 @@ import java.io.IOException;
import org.dcache.nfs.v4.xdr.length4;
import org.dcache.nfs.v4.xdr.uint32_t;
public class ff_layout4 implements XdrAble, java.io.Serializable {
public class ff_layout4 implements XdrAble {
public length4 ffl_stripe_unit;
public ff_mirror4 [] ffl_mirrors;
public uint32_t ffl_flags4;
public uint32_t ffl_stats_collect_hint;
private static final long serialVersionUID = 9097043134498097746L;
public ff_layout4() {
}
......
......@@ -13,11 +13,9 @@ import org.dcache.oncrpc4j.xdr.XdrDecodingStream;
import org.dcache.oncrpc4j.xdr.XdrEncodingStream;
import java.io.IOException;
public class ff_layouthint4 implements XdrAble, java.io.Serializable {
public class ff_layouthint4 implements XdrAble {
public ff_mirrors_hint fflh_mirrors_hint;
private static final long serialVersionUID = 5904359426929067786L;
public ff_layouthint4() {
}
......
......@@ -13,12 +13,10 @@ import org.dcache.oncrpc4j.xdr.XdrDecodingStream;
import org.dcache.oncrpc4j.xdr.XdrEncodingStream;
import java.io.IOException;
public class ff_layoutreturn4 implements XdrAble, java.io.Serializable {
public class ff_layoutreturn4 implements XdrAble {
public ff_ioerr4 [] fflr_ioerr_report;
public ff_iostats4 [] fflr_iostats_report;
private static final long serialVersionUID = -1266201700985015117L;
public ff_layoutreturn4() {
}
......
......@@ -16,7 +16,7 @@ import org.dcache.nfs.v4.xdr.netaddr4;
import org.dcache.nfs.v4.xdr.nfs_fh4;
import org.dcache.nfs.v4.xdr.nfstime4;
public class ff_layoutupdate4 implements XdrAble, java.io.Serializable {
public class ff_layoutupdate4 implements XdrAble {
public netaddr4 ffl_addr;
public nfs_fh4 ffl_fhandle;
public ff_io_latency4 ffl_read;
......@@ -24,8 +24,6 @@ public class ff_layoutupdate4 implements XdrAble, java.io.Serializable {
public nfstime4 ffl_duration;
public boolean ffl_local;
private static final long serialVersionUID = 7916998994578483964L;
public ff_layoutupdate4() {
}
......
......@@ -13,11 +13,9 @@ import org.dcache.oncrpc4j.xdr.XdrDecodingStream;
import org.dcache.oncrpc4j.xdr.XdrEncodingStream;
import java.io.IOException;
public class ff_mirror4 implements XdrAble, java.io.Serializable {
public class ff_mirror4 implements XdrAble {
public ff_data_server4 [] ffm_data_servers;
private static final long serialVersionUID = 3815279288438096533L;
public ff_mirror4() {
}
......
......@@ -14,12 +14,10 @@ import org.dcache.oncrpc4j.xdr.XdrEncodingStream;
import java.io.IOException;
import org.dcache.nfs.v4.xdr.uint32_t;
public class ff_mirrors_hint implements XdrAble, java.io.Serializable {
public class ff_mirrors_hint implements XdrAble {
public boolean ffmc_valid;
public uint32_t ffmc_mirrors;
private static final long serialVersionUID = 2356648982057016891L;
public ff_mirrors_hint() {
}
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment