src: move nfs4 client code into basic-client module

Motivation:
The nfsv4 client code is for testing purposes only. In addition it adds
an extra dependency which is not required by server part.

Modification:
move nfs4 client code into basic-client module.

Result:
reduced transient dependency and testing code from the core components.

Acked-by: Albert Rossi
Target: master

basic-client/pom.xml

@@ -58,8 +58,8 @@
             <version>${project.version}</version>
         </dependency>
         <dependency>
-            <groupId>org.slf4j</groupId>
-            <artifactId>log4j-over-slf4j</artifactId>
+            <groupId>org.jline</groupId>
+            <artifactId>jline</artifactId>
         </dependency>
         <dependency>
             <groupId>ch.qos.logback</groupId>

core/src/main/java/org/dcache/nfs/v4/client/FileIoDevice.java → basic-client/src/main/java/org/dcache/nfs/v4/client/FileIoDevice.java

 /*
- * Copyright (c) 2009 - 2014 Deutsches Elektronen-Synchroton,
+ * Copyright (c) 2009 - 2020 Deutsches Elektronen-Synchroton,
  * Member of the Helmholtz Association, (DESY), HAMBURG, GERMANY
  *
  * This library is free software; you can redistribute it and/or modify

core/src/main/java/org/dcache/nfs/v4/client/GetDeviceListStub.java → basic-client/src/main/java/org/dcache/nfs/v4/client/GetDeviceListStub.java

 /*
- * Copyright (c) 2009 - 2017 Deutsches Elektronen-Synchroton,
+ * Copyright (c) 2009 - 2020 Deutsches Elektronen-Synchroton,
  * Member of the Helmholtz Association, (DESY), HAMBURG, GERMANY
  *
  * This library is free software; you can redistribute it and/or modify

core/src/main/java/org/dcache/nfs/v4/client/GetdeviceinfoStub.java → basic-client/src/main/java/org/dcache/nfs/v4/client/GetdeviceinfoStub.java

 /*
- * Copyright (c) 2009 - 2014 Deutsches Elektronen-Synchroton,
+ * Copyright (c) 2009 - 2020 Deutsches Elektronen-Synchroton,
  * Member of the Helmholtz Association, (DESY), HAMBURG, GERMANY
  *
  * This library is free software; you can redistribute it and/or modify

core/src/main/java/org/dcache/nfs/v4/client/LayoutgetStub.java → basic-client/src/main/java/org/dcache/nfs/v4/client/LayoutgetStub.java

 /*
- * Copyright (c) 2009 - 2014 Deutsches Elektronen-Synchroton,
+ * Copyright (c) 2009 - 2020 Deutsches Elektronen-Synchroton,
  * Member of the Helmholtz Association, (DESY), HAMBURG, GERMANY
  *
  * This library is free software; you can redistribute it and/or modify

core/src/main/java/org/dcache/nfs/v4/client/Main.java → basic-client/src/main/java/org/dcache/nfs/v4/client/Main.java

 /*
- * Copyright (c) 2009 - 2019 Deutsches Elektronen-Synchroton,
+ * Copyright (c) 2009 - 2020 Deutsches Elektronen-Synchroton,
  * Member of the Helmholtz Association, (DESY), HAMBURG, GERMANY
  *
  * This library is free software; you can redistribute it and/or modify
@@ -54,6 +54,7 @@ import org.jline.terminal.TerminalBuilder;
 import org.dcache.nfs.v4.xdr.COMPOUND4args;
 import org.dcache.nfs.v4.xdr.COMPOUND4res;
 import org.dcache.nfs.ChimeraNFSException;
+import org.dcache.nfs.v4.CompoundBuilder;
 import org.dcache.nfs.v4.Stateids;
 import org.dcache.nfs.v4.xdr.clientid4;
 import org.dcache.nfs.v4.xdr.deviceid4;

core/src/main/java/org/dcache/nfs/v4/client/Stripe.java → basic-client/src/main/java/org/dcache/nfs/v4/client/Stripe.java

 /*
- * Copyright (c) 2009 - 2018 Deutsches Elektronen-Synchroton,
+ * Copyright (c) 2009 - 2020 Deutsches Elektronen-Synchroton,
  * Member of the Helmholtz Association, (DESY), HAMBURG, GERMANY
  *
  * This library is free software; you can redistribute it and/or modify

core/src/main/java/org/dcache/nfs/v4/client/StripeMap.java → basic-client/src/main/java/org/dcache/nfs/v4/client/StripeMap.java

 /*
- * Copyright (c) 2009 - 2012 Deutsches Elektronen-Synchroton,
+ * Copyright (c) 2009 - 2020 Deutsches Elektronen-Synchroton,
  * Member of the Helmholtz Association, (DESY), HAMBURG, GERMANY
  *
  * This library is free software; you can redistribute it and/or modify

core/pom.xml

@@ -66,10 +66,6 @@
             <artifactId>jimfs</artifactId>
             <scope>test</scope>
         </dependency>
-        <dependency>
-            <groupId>org.jline</groupId>
-            <artifactId>jline</artifactId>
-        </dependency>
         <dependency>
             <groupId>junit</groupId>
             <artifactId>junit</artifactId>

core/src/main/java/org/dcache/nfs/v4/client/CompoundBuilder.java → core/src/main/java/org/dcache/nfs/v4/CompoundBuilder.java

 /*
- * Copyright (c) 2009 - 2019 Deutsches Elektronen-Synchroton,
+ * Copyright (c) 2009 - 2020 Deutsches Elektronen-Synchroton,
  * Member of the Helmholtz Association, (DESY), HAMBURG, GERMANY
  *
  * This library is free software; you can redistribute it and/or modify
@@ -17,7 +17,7 @@
  * details); if not, write to the Free Software Foundation, Inc.,
  * 675 Mass Ave, Cambridge, MA 02139, USA.
  */
-package org.dcache.nfs.v4.client;
+package org.dcache.nfs.v4;
 
 import org.dcache.nfs.v4.xdr.layoutreturn_file4;
 import org.dcache.nfs.v4.xdr.nfs_fh4;

core/src/test/java/org/dcache/nfs/v4/NFS4ClientTest.java

 /*
- * Copyright (c) 2009 - 2018 Deutsches Elektronen-Synchroton,
+ * Copyright (c) 2009 - 2020 Deutsches Elektronen-Synchroton,
  * Member of the Helmholtz Association, (DESY), HAMBURG, GERMANY
  *
  * This library is free software; you can redistribute it and/or modify
@@ -39,7 +39,6 @@ import static org.dcache.nfs.v4.NfsTestUtils.createClient;
 import org.dcache.nfs.v4.xdr.seqid4;
 import org.dcache.nfs.v4.xdr.state_owner4;
 import static org.dcache.nfs.v4.NfsTestUtils.generateRpcCall;
-import org.dcache.nfs.v4.client.CompoundBuilder;
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.assertEquals;

core/src/test/java/org/dcache/nfs/v4/NfsTestUtils.java

 /*
- * Copyright (c) 2009 - 2019 Deutsches Elektronen-Synchroton,
+ * Copyright (c) 2009 - 2020 Deutsches Elektronen-Synchroton,
  * Member of the Helmholtz Association, (DESY), HAMBURG, GERMANY
  *
  * This library is free software; you can redistribute it and/or modify

core/src/test/java/org/dcache/nfs/v4/OperationCREATE_SESSIONTest.java

 /*
- * Copyright (c) 2009 - 2017 Deutsches Elektronen-Synchroton,
+ * Copyright (c) 2009 - 2020 Deutsches Elektronen-Synchroton,
  * Member of the Helmholtz Association, (DESY), HAMBURG, GERMANY
  *
  * This library is free software; you can redistribute it and/or modify
@@ -19,7 +19,6 @@
  */
 package org.dcache.nfs.v4;
 
-import org.dcache.nfs.v4.client.CompoundBuilder;
 import org.dcache.nfs.v4.xdr.COMPOUND4args;
 import org.dcache.nfs.v4.xdr.COMPOUND4res;
 import org.dcache.nfs.v4.xdr.sequenceid4;

core/src/test/java/org/dcache/nfs/v4/OperationEXCHANGE_IDTest.java

 /*
- * Copyright (c) 2009 - 2018 Deutsches Elektronen-Synchroton,
+ * Copyright (c) 2009 - 2020 Deutsches Elektronen-Synchroton,
  * Member of the Helmholtz Association, (DESY), HAMBURG, GERMANY
  *
  * This library is free software; you can redistribute it and/or modify
@@ -19,7 +19,6 @@
  */
 package org.dcache.nfs.v4;
 
-import org.dcache.nfs.v4.client.CompoundBuilder;
 import org.dcache.nfs.v4.xdr.nfs_argop4;
 import org.dcache.nfs.v4.xdr.state_protect_how4;
 import org.dcache.nfs.v4.xdr.nfs4_prot;

core/src/test/java/org/dcache/nfs/v4/OperationGETXATTRTest.java

@@ -2,7 +2,6 @@ package org.dcache.nfs.v4;
 
 import java.io.IOException;
 import java.nio.charset.StandardCharsets;
-import org.dcache.nfs.v4.client.CompoundBuilder;
 import org.dcache.nfs.v4.xdr.COMPOUND4args;
 import org.dcache.nfs.v4.xdr.COMPOUND4res;
 import org.dcache.nfs.v4.xdr.nfs_fh4;

core/src/test/java/org/dcache/nfs/v4/OperationLAYOUTCOMMITTest.java

@@ -9,7 +9,6 @@ import org.dcache.nfs.vfs.Inode;
 import org.junit.Before;
 import org.junit.Test;
 
-import org.dcache.nfs.v4.client.CompoundBuilder;
 import org.dcache.nfs.v4.xdr.COMPOUND4args;
 import org.dcache.nfs.v4.xdr.COMPOUND4res;
 import org.dcache.nfs.v4.xdr.layouttype4;

core/src/test/java/org/dcache/nfs/v4/OperationLAYOUTERRORTest.java

@@ -2,7 +2,6 @@ package org.dcache.nfs.v4;
 
 import java.io.IOException;
 import org.dcache.nfs.status.NotSuppException;
-import org.dcache.nfs.v4.client.CompoundBuilder;
 import org.dcache.nfs.v4.xdr.COMPOUND4args;
 import org.dcache.nfs.v4.xdr.device_error4;
 import org.dcache.nfs.vfs.VirtualFileSystem;

core/src/test/java/org/dcache/nfs/v4/OperationLAYOUTSTATSTest.java

@@ -2,7 +2,6 @@ package org.dcache.nfs.v4;
 
 import java.io.IOException;
 import org.dcache.nfs.status.NotSuppException;
-import org.dcache.nfs.v4.client.CompoundBuilder;
 import org.dcache.nfs.v4.xdr.COMPOUND4args;
 import org.dcache.nfs.v4.xdr.deviceid4;
 import org.dcache.nfs.v4.xdr.io_info4;

core/src/test/java/org/dcache/nfs/v4/OperationLISTXATTRSTest.java

@@ -2,7 +2,6 @@ package org.dcache.nfs.v4;
 
 import java.io.IOException;
 import java.nio.charset.StandardCharsets;
-import org.dcache.nfs.v4.client.CompoundBuilder;
 import org.dcache.nfs.v4.xdr.COMPOUND4args;
 import org.dcache.nfs.v4.xdr.COMPOUND4res;
 import org.dcache.nfs.v4.xdr.nfs_fh4;