1. 15 Jun, 2021 1 commit
  2. 02 Jun, 2021 1 commit
  3. 26 Jan, 2021 1 commit
  4. 14 Apr, 2020 1 commit
  5. 07 Apr, 2020 1 commit
  6. 13 Feb, 2020 1 commit
  7. 13 Sep, 2019 1 commit
  8. 20 Sep, 2017 1 commit
    • Eric Cano's avatar
      Fixed long updating of statistics in object store leading to timeout. · 0c28e713
      Eric Cano authored
      The updating of statistic in the objecttore (in drive register) could wait for a lock
      for so long that the session get killed due to a heatbeat timeout.
      
      To avoid this, we use lockfree access as much as possible, and when locking it srequired, do it with a
      timeout.
      
      The timeout will be logged as a warning.
      
      Added timeouts to synchronous locking primitives in the object store backends to implement this feature.
      
      Fixed a bug where the VFS backend always used exclusive locks.
      0c28e713
  9. 12 Jul, 2017 1 commit
  10. 27 Jun, 2017 1 commit
  11. 13 Apr, 2017 1 commit
  12. 30 Mar, 2017 1 commit
  13. 15 Dec, 2016 1 commit
  14. 11 Oct, 2016 1 commit
    • Victor Kotlyar's avatar
      Ported commits from castor/master for Encryption: · 1a3812e0
      Victor Kotlyar authored
      6b6374d6c2e209c98c0d4d7aa665e1df83d71aaa
        CASTOR-5350: Introduce encryption SCSI commands in tape drive
        backend
      
        Implementation of two methods:
          * setEncryptionKey(key): Sets encryption params to drive.
          * clearEncryptionKey: Clears encryption params from drive.
      
      3cf91d48f5c7b0cb563c3037aee69ec769f5ab94
        Added support for an interface script that will setup drive
        encryption per tape
      
      e9ca601687508de20fab7154e63bb0dbd1b25a8a
        Migrate TapeWriteSingleThread::TapeCleaning::~TapeCleaning() body to
        .cpp
      
      266b02d8175b5cfc0b688135cbdc335e93060b
        CASTOR-5350: Refactor support for only external key management script
      
      789b26a0bc69053ff1ab792a02676a7753f093ed
        Merge branch 'encryption_backend' into 'master'
      
        CASTOR-5350: Encryption backend
      
        ## Description
          The aim of this merge request is to incorporate encryption support
          into CASTOR.
          The proposed changes are to be used in conjunction with the
          operators'
          [ExternalEncryptionKeyScript](https://gitlab.cern.ch/slaskari/castor-get-encryption-key).
      
          The **aim** is to enable encryption in specific tape pools of
          CASTOR.
        ## Changes
          * Introduce encryption SCSI backend to DriveGeneric.
          * Introduce encryption control wrapper
          * (`castor/tape/tapeserver/daemon/EncryptionControl`) for
          * abstracting the two sub-components of:
            * Calling the `ExternalEncryptionKeyScript`,
            * Calling the equivalent DriveGeneric function for
            * passing/clearing the encryption parameters to/from the drive.
          * Add new configuration option in `castor.conf` for the external key
          * management script.
          * Create a Subprocess wrapper for executing external commands as
          * CASTOR children (`castor/server/Subprocess.{h,c}pp`).
          * Incorporate encryption handling in the:
            * DataTransferSession
            * LabelSession
            * CleanerSession
          * Add encryption control timer in the task Watchdog.
        See merge request !1
      
      fa550707c42d80466bbd448e355aaf9be5ea8e04
        Clear encryption key only when encryption enabled
        Changes include:
          - Making EncryptionControl stateful
          - Calling clearEncryptionKey on the drive only when encryption is
            on.
        Also includes a minor duplicate code fix on DriveGeneric.
      cf4eb9f3ae36c9cfc9c40349d69ab6642020e81e
        Merge branch 'encryption_changes' into 'master'
        Clear encryption key only when encryption enabled
        ## Description
          Changes include:
          - Making EncryptionControl stateful
          - Calling `clearEncryptionKey()` on the drive only when encryption
            is on.
          Also includes a minor duplicate code fix on **DriveGeneric.cpp**.
        See merge request !2
      
      40366d963ee33ca081df6c991189b21369e461fd
        Check if the drive has encryption capability enabled:
          * Add isEncryptionCapEnabled() vendor-specific function
          * Check isEncryptionCapEnabled() before passing encryption params
          * Check isEncryptionCapEnabled() before clearing encryption params
          * Clear encryption key before unencrypted I/O
      
      4ccc661d01eccfc3fdfb9ee2578d15a147a0c55a
        Merge branch 'encryption_capability_enabled' into 'master'
        Drive encryption capabilities inclusion
        ## Description
          The aim of this merge request is to address issues related to
          encryption on drive without the encryption capability enabled.
          More specifically:
            * It introduces a vendor-specific way of identifying if the drive
            * has encryption capability enabled
            * **IBM**: Through the SPIN index SCSI page
            * **Oracle**: Through the general INQUIRY SCSI page
            * If the data to be written are to be encrypted, an additional check
            * of the encryption capability of the drive is made. In case of
            * encrypted data, but no encryption capability, the session fails.
            In essence, all encryption related operations are made modulo the
          encryption capability of the drive.
            Last, in case of unencrypted I/O, we clear the keys of the drive (if
          encryption capable) to avoid encrypted data with previous keys on
          CASTOR's system failure.
        ## Testing
          Before the merge request's submission, the following tests were
          passed:
            On drives with **encryption capability enabled**:
              * Label session
              * Label with previously set encryption key
              * Write without encryption
              * Read without encryption
              * Write with encryption
              * Read with encryption
              * Write with previously set encryption key
              * Read with previously set encryption key
            On drive with **encryption cabability disabled**:
              * Label session
              * Write without encryption
              * Read without encryption
              * Write with encryption - session **should** fail
              * Read with encryption - session **should** fail
          See merge request !3
      
      55b85a2cb4681d697565116c00ff98c6becea4fb
        Secure session against invalid encryption script output
      
      3a54875c680fe6c1c9d5cf25cf98d2780196e0d1
        Changes in encryption workflow
          - VMGR tag is updated only on write operations
          - Empty key signifies no encryption
      
      f5408cf0ccbae9a4ab94a533f3b6d7be323f72fb
        Minor encryption log enhancements
          * Error line in Read/Write session with ErrorMesage key
          * Fix for delimiter in the end of arguments in argsToString()
      2e7204fb0dd24b472a959fa5e13320c34df4f017
        Merging in improvements on tape encryption support.
      
      92533a1746d0744ee528781558a720c63ca3c4d1
        Removed nullptr which is not supported in SLC6's gcc.
        Added automatic deletion of json objects in
        EncryptionControl::parse_json_script_output.
      
      fca3bb9e7fce364b429fc0b5c036fb752fd67ff1
        Fix log typo
      1a3812e0
  15. 07 Oct, 2016 1 commit
  16. 06 Oct, 2016 1 commit
    • Victor Kotlyar's avatar
      Ported commit fab791bc805f95d59c55cbcb554e6f218710b0dd from castor/master · 425af9d0
      Victor Kotlyar authored
      CASTOR-4836: tapeserverd should have a new time counter: delivery time
      
      Fixed.
      
      Add two counters: deliveryTime and drainingTime. For the recall
      session deliveryTime is the total time of the disk threads and
      drainigTime is the time difference between deliveryTime and
      the total time of the tape thread or in other words how much time
      disk threads spent after the tape thread finished. For the
      migration session deliveryTime is the total time of the tape thread
      and drainingTime always equal 0.
      425af9d0
  17. 09 Sep, 2016 1 commit
  18. 06 Sep, 2016 1 commit
  19. 05 Sep, 2016 1 commit
  20. 29 Aug, 2016 1 commit
    • Eric Cano's avatar
      Simplified the interface of the TapedProxy and TapeServerReporter. · 2bf36ce4
      Eric Cano authored
      The TapeServerReporter, which is the main interface for the tape thread and tasks,
      now has a simple reportState() function instead of mnay ad-hoc ones. The only ones
      remaining are reportTapeUnmountedForRetrieve() and reportDiskCompleteForRetrieve()
      as they allow managing the special case of retrieve where the session can from
      Running to either ShutingDown or DrainingToDisk depending on which order the
      threads complete.
      
      The actual calls to send messages to taped are now 3: reportState,
      addLog, removeLog.
      2bf36ce4
  21. 24 Aug, 2016 1 commit
  22. 18 Aug, 2016 1 commit
  23. 14 Jul, 2016 1 commit
  24. 25 May, 2016 1 commit
    • Eric Cano's avatar
      Started morphing the code to accomodate both the move some data structure from... · 7724a676
      Eric Cano authored
      Started morphing the code to accomodate both the move some data structure from OStoreDB to catalogue and shared structures modifications.
      Renamed class members using underscode instead of mixed case.
      Removed mount criteria from in-memory tape pool representation.
      Removed support for path of archive files for in-memory representations.
      Removed all but maxDrives allowed from in-memory representation of mount
      policy.
      Created new constructor for UserIdentity.
      Switch the UserIdentity used by RemoteFileStatus.
      Renamed TapePoolQueue to ArchiveQueue.
      Replaced CreationLog usages with EntryLog.
      Renamed TapeQueue to RetrieveQueue.
      Removed support for data now gone to catalogue from RootEntry.
      Removed corresponding structures from object store.
      Removed corresponding calls from SchedulerDatabase and inheriting
      classes (OStoreDB).
      7724a676
  25. 15 Feb, 2016 1 commit
  26. 12 Feb, 2016 1 commit
  27. 08 Oct, 2015 1 commit
  28. 04 Sep, 2015 1 commit
  29. 13 Aug, 2015 1 commit
  30. 16 Jul, 2015 2 commits
  31. 15 Jul, 2015 2 commits
  32. 25 Jun, 2015 1 commit
  33. 23 Feb, 2015 1 commit
  34. 11 Dec, 2014 1 commit
  35. 05 Dec, 2014 1 commit
  36. 02 Dec, 2014 1 commit
  37. 19 Nov, 2014 1 commit
    • Eric Cano's avatar
      CASTOR-4832: tapeserverd should report error counts in the end of session statistics · 08e744a3
      Eric Cano authored
      Propagated references to the watchdog to disk and tape threads and tasks.
      Added a maps for storing the count of all errors that occured during the session.
      Added propagation of the counts to the initial process.
      Added error reporting in disk and tapes threads and tasks by using a string marker
      allowing to know which part went wrong in high level exception. Exceptions then
      bumps up the count in the watchdog (synchronously), and the watchdog sends the
      new count to the initial thread later (in the watchdog's thread).
      Plus some missing logs fixed when an exception is thrown in a disk write task.
      
      Added interface to reference the recall watchdog to the recall disk thread pool.
      Next: Do same for migration. Actually store the reference. Add new error map storing in watchdog. Add error reporting in tape and disk threads.
      
      WIP: Added missing file ID for disk write thread. Added missing error log when an exception is thrown in a disk write task.
      
      WIP: switching to CASTOR-4839 tapeserverd: task injector should decide on closing the session earlier
      
      WIP. Next: log unmount errors (in the RAII)
      
      Finished error counting in data threads.
      08e744a3
  38. 11 Nov, 2014 1 commit