GitLab

If the disk threads are not finished after the TapeReadSingleThread finished, the status of the drive will be "DrainingToDisk"
This removed a RecallReportPacker exception when trying to release disk space reservation for backpressure

or write.

Implements setTapeMounted in the scheduler interface for RetrieveMount
and ArchiveMount.

The retrieve requests now carry all the information necessary to create the archive jobs.
Retrive requests carry an isRepack boolean. The distinction between repack and non-repack behaviour
is pushed as low as possible in the api (in the object store) so that client code can be more
generic. For the same reason, the
The expand repack mode (re-creation of missing tape files) is not supported yet.
Changed the represenation of copy numbers to uint32 (as this is the smalled number supported but protocol buffers).
Added ArchiveRoute::StorageClassMap and ArchiveRoute::FullMap to store archive routing in memory.
Added repack buffer base URL support, and mechanism to compute temporary copy location in disk cache.
Fixed bug in ObjectOps<>::asyncInsert();
Inplemented the path generation for repack disk storage (<BaseURL>/<VID>/<FSeq (09%d)>).

The error(s) gets recorded at failure time, and the list is printed at
job deletion time.

Proceed all successful reports asynchronously and periodically check
and clear statuses if they have finished.
In the end of session do the check/flush for all reports in the
successful reports queue.

Switch from synchronous rados remove to async aio_remove in
case of zero size object in BackendRados::AsyncUpdater

The retrieve request now gets properly queued in case of retrieve error.
The errors are counted and the request gets deleted eventually.
A new field was added to the retrive request in object store. This commit
will fail on upgrade if there are retrieve requests still queued at update time.
Cleaned up some unused structures in cta.proto
Minor modifications to ArchiveJobs.

The timeout is now set to zero in unit tests.

Added drive status reporting in scheduler
Added drive status reporting in OStoreDB
Added support for drive status listing in the front end
Removed virtual functions from the Scheduler, which is never overloaded.
Added DesiredDriveState structure to drive state.
Removed usage of duplicate MountType, DriveStatus and DriveState structures.
Created DriveInfo structure to allow recreation of drive register entry in all
reporting situation (potentially with partial/assumed info).

Fixed the end of session logic for the recall report packer to eliminate the memory leak worked around in the previous commits.

The error logs are now gone.
Adapted the recall report packer unit test.

The following two test classes contained the same test class:

  tapeserver/castor/tape/tapeserver/daemon/MigrationReportPackerTest.cpp
  tapeserver/castor/tape/tapeserver/daemon/RecallReportPackerTest.cpp

They both defined and declared the class castor_tape_tapeserver_daemonTest.

When I added a member to one of the duplicate classes I got memory
corruption that valgrind detected but gave difficult to understand
error messages.

This implied removing tpconfig, tplabel and tpstat.

Partial commit to make the status update mechanism work (many many changes), compiles and passes unit tests now

Refactored the Mocks to eliminate code duplication. (for Mock{Archive|Retrieve}{Job}Mount}

Adjusted unit test to accomodate the new structure (SchedulerDatabase::RetrieveMount is now a pure virtual class).

Removed usage of the mock scheduler database that will not be updated for further modification in the scheduler database interface.

Improved the RecallReportPackerBadBadEnd test, though it still does not pass because the expected error log is never created

RecallReportPackerNominal in the context of the CTA project

Please note that I still must complete the remaining unit tests
within the RecallReportPackerTest.cpp file.

Renamed CTA/tapeserver/castor to CTA/tapeserver/castor_checkout in preparation for the moving the sub-directory CTA/tapeserver/castor/castor up the directory tree

Fixed.

Removed "h/" from all #includes.