GitLab

00050-CASTOR-5279-Logical-Block-Protection-support-in-the-.patch 348300861522b28c6e74cf8a919e40509151241d

Renamed CTA/tapeserver/castor to CTA/tapeserver/castor_checkout in preparation for the moving the sub-directory CTA/tapeserver/castor/castor up the directory tree

In a previous commit I removed the inheritance relationship between
ZmqSocket and ZmqSocketMT.  I used templated functions in order to
be able to handle instances of ZmqSocket and ZmqSocketMT with thei
same code.  I now believe that decision was wrong in the long run.
Future code maintainers will not know that a ZmqSocketMT object is
a type of ZmqSocket.  Eclipse and doxygen are very good at
providing class hierarchies.  One should benefit from this when one
can as it is a form of free documentation.

My previous commit not only removed inheritance, it also allowed
the multi-threaded version of ZMQSocket to contain the single
threaded version as opposed to inherit from it.  Using composition
over inheritance prevented future mistakes where somebody adds a
new thread-unsafe method to the super class and forgets or doesn’t
know that they should implement a thread-safe overriding version in
the sub-class.  This commit preserves composition over inheritance.

There are now three “ZmqSocket” classes: ZmqSocket, ZmqSocketST and
ZmqSocketMT.  ZmqSocket itself is now abstract and simply defines
the methods such a socket should implement.  ZmqSocketST is ai
concrete class for single-threaded use (hence ST) and
ZmqSocketMT is for multithreaded use (hence MT).

ZmqSocketST inherits from ZmqSocket and  ZmqSocketMT also inherits
from ZmqSocket.  ZmqSocketMT does not inherit from ZmqSocketST.
ZmqSocketMT contains an instance of ZmqSocketST therefore preserving
the composition over inheritance solution of the previous commit.

The exception class named castor::exception::Exception provides the same
functionality as castor::exception::Internal and therefore one of them
had to go for the sake of removing redundant code.

Conflicts:

	castor/tape/mighunter/StreamThread.cpp

- Mutex timeout can be specified as parameter, to be passed to BaseThreadPool's ctor.

still not implemented.

It does compile, going to be tested.