GitLab

Moved disk-operations-related code into the new "disk" directory

CASTOR-4889: tapeserverd's end of session summary could indicate the
files still open

Fixed.

Add reports for still open files in the "Tape session finished"
log message to indicate problematic disk servers. It should be
only visible in case of kill of the data transfer session.

Replaced castor file header with CTA file header

Moved castor::server::
  BlockingQueue
  Semaphores
  AtomicCounter
  AtomicFlag
into cta::threading::

Please note that you will have to install the following CASTOR rpms
in order to compile:

  castor
  castor-devel
  castor-lib
  castor-lib-server
  castor-lib-tape

Renamed CTA/tapeserver/castor to CTA/tapeserver/castor_checkout in preparation for the moving the sub-directory CTA/tapeserver/castor/castor up the directory tree

Propagated references to the watchdog to disk and tape threads and tasks.
Added a maps for storing the count of all errors that occured during the session.
Added propagation of the counts to the initial process.
Added error reporting in disk and tapes threads and tasks by using a string marker
allowing to know which part went wrong in high level exception. Exceptions then
bumps up the count in the watchdog (synchronously), and the watchdog sends the
new count to the initial thread later (in the watchdog's thread).
Plus some missing logs fixed when an exception is thrown in a disk write task.

Added interface to reference the recall watchdog to the recall disk thread pool.
Next: Do same for migration. Actually store the reference. Add new error map storing in watchdog. Add error reporting in tape and disk threads.

WIP: Added missing file ID for disk write thread. Added missing error log when an exception is thrown in a disk write task.

WIP: switching to CASTOR-4839 tapeserverd: task injector should decide on closing the session earlier

WIP. Next: log unmount errors (in the RAII)

Finished error counting in data threads.

The offending message has been changed in a previous case: CASTOR-4749

Reviewed all bandwidth calculations to homogenize the statistics printing.
Fixed a bug where the total time for a session was not properly retrieved before logging, leading to NaN printouts.

Tapeserverd now support file://, root:// rfio:// and radosStriper:// URLs, on top of heuristic protocol guessing from the hostname:[/]path synthax.
The rados striper version is not yet fleshed out yet.
The xroot client used for this is the latest object oriented client (XrdCl::File).

Reviewed and fixed the error handling for migrations.
A deadlock was created by the competing usage of a stop variable an normal information flow
through the threads. The global variable's usage has been reduced and clarified:
it is set by the tape thread to indicated an error reached it. From that point
on, the remaining disk threads can stop what they are doing (and not before as failing
to read a file should not block the completion of previous ones).
The file errors are now transmitted to the client before end of session, and in case of flush.
The unit tests have been updated accordingly.
Report messages have been improved.

Fixed unnecessary virtual declarations in classes without inheritance (only detected by the SLC5 compiler).

Removed interface classes DiskReadTaskInterface, DiskWriteTaskInterface, DiskThreadPoolInterface

in order to no even move the little finger if a previous task failed
Also added some comments

If a Diskread ou TapeWrite task fails, all others stop and clean memory blocks while the task injector discards all remaining requests

and DiskReadThreadPool

The circulation of the blocks in case of error is now done according to the number of mem blocks initially needed to transfer the whole file

Cleaned up interfaces to removed endOfWork remains and make functions virtual pure when it was possible

DiskReadTask -> DiskReadTaskInterface, DiskReadFileTask -> DiskReadTask, same thing for the write side. Changed the includes files accordingly