1. 15 Jun, 2021 1 commit
  2. 02 Jun, 2021 1 commit
  3. 25 Sep, 2020 15 commits
  4. 29 Aug, 2017 2 commits
  5. 28 Aug, 2017 1 commit
  6. 15 Aug, 2017 1 commit
  7. 26 May, 2017 3 commits
    • Cristina Moraru's avatar
    • Cristina Moraru's avatar
      After feedback · d5a8098c
      Cristina Moraru authored
      Signed-off-by: default avatarCristina Moraru <cristina-gabriela.moraru@cern.ch>
    • Cristina Moraru's avatar
      Implement RAO at the drive level #57 · c8b74a53
      Cristina Moraru authored
      This commit adds the feature of querying the drive for the
      Recommended Access Order (RAO) of a series of files and adds
      a test file for this feature.
      Changes of this commit:
        *  Extend the DriveInterface with a virtual method queryRAO
      which takes as parameter the name of the file containing a set
      of files for which the RAO is requested. The line format of this
      file is the following:
        *  Extend DriveGeneric class with the implementation of the
      method queryRAO, along with a few other auxiliary methods; some
      key auxiliary methods are getLimitUDS, generateRAO, receiveRAO
        *  Add method queryRAO in object FakeDrive returning Exception:
      Not Implemented
        *  Add auxiliary constants and structures in a new 'RAO' namespace
        *  Add test file: BasicReadWriteTest.cpp which can perform 3 tests
      according to the setting of variable 'test'
      	1. BLOCK_TEST - basic read / write of blocks
      	2. FILE_TEST - writes a series of CASTOR files and reads
      a random one
      	3. RAO_TEST - performs a RAO query for a series of files
      given in the filename specified in argv[1]. The file format should
      respect the above mentioned order.
      Signed-off-by: default avatarCristina Moraru <cristina-gabriela.moraru@cern.ch>
  8. 25 Feb, 2017 1 commit
  9. 16 Nov, 2016 1 commit
  10. 11 Oct, 2016 1 commit
    • Victor Kotlyar's avatar
      Ported commits from castor/master for Encryption: · 1a3812e0
      Victor Kotlyar authored
        CASTOR-5350: Introduce encryption SCSI commands in tape drive
        Implementation of two methods:
          * setEncryptionKey(key): Sets encryption params to drive.
          * clearEncryptionKey: Clears encryption params from drive.
        Added support for an interface script that will setup drive
        encryption per tape
        Migrate TapeWriteSingleThread::TapeCleaning::~TapeCleaning() body to
        CASTOR-5350: Refactor support for only external key management script
        Merge branch 'encryption_backend' into 'master'
        CASTOR-5350: Encryption backend
        ## Description
          The aim of this merge request is to incorporate encryption support
          into CASTOR.
          The proposed changes are to be used in conjunction with the
          The **aim** is to enable encryption in specific tape pools of
        ## Changes
          * Introduce encryption SCSI backend to DriveGeneric.
          * Introduce encryption control wrapper
          * (`castor/tape/tapeserver/daemon/EncryptionControl`) for
          * abstracting the two sub-components of:
            * Calling the `ExternalEncryptionKeyScript`,
            * Calling the equivalent DriveGeneric function for
            * passing/clearing the encryption parameters to/from the drive.
          * Add new configuration option in `castor.conf` for the external key
          * management script.
          * Create a Subprocess wrapper for executing external commands as
          * CASTOR children (`castor/server/Subprocess.{h,c}pp`).
          * Incorporate encryption handling in the:
            * DataTransferSession
            * LabelSession
            * CleanerSession
          * Add encryption control timer in the task Watchdog.
        See merge request !1
        Clear encryption key only when encryption enabled
        Changes include:
          - Making EncryptionControl stateful
          - Calling clearEncryptionKey on the drive only when encryption is
        Also includes a minor duplicate code fix on DriveGeneric.
        Merge branch 'encryption_changes' into 'master'
        Clear encryption key only when encryption enabled
        ## Description
          Changes include:
          - Making EncryptionControl stateful
          - Calling `clearEncryptionKey()` on the drive only when encryption
            is on.
          Also includes a minor duplicate code fix on **DriveGeneric.cpp**.
        See merge request !2
        Check if the drive has encryption capability enabled:
          * Add isEncryptionCapEnabled() vendor-specific function
          * Check isEncryptionCapEnabled() before passing encryption params
          * Check isEncryptionCapEnabled() before clearing encryption params
          * Clear encryption key before unencrypted I/O
        Merge branch 'encryption_capability_enabled' into 'master'
        Drive encryption capabilities inclusion
        ## Description
          The aim of this merge request is to address issues related to
          encryption on drive without the encryption capability enabled.
          More specifically:
            * It introduces a vendor-specific way of identifying if the drive
            * has encryption capability enabled
            * **IBM**: Through the SPIN index SCSI page
            * **Oracle**: Through the general INQUIRY SCSI page
            * If the data to be written are to be encrypted, an additional check
            * of the encryption capability of the drive is made. In case of
            * encrypted data, but no encryption capability, the session fails.
            In essence, all encryption related operations are made modulo the
          encryption capability of the drive.
            Last, in case of unencrypted I/O, we clear the keys of the drive (if
          encryption capable) to avoid encrypted data with previous keys on
          CASTOR's system failure.
        ## Testing
          Before the merge request's submission, the following tests were
            On drives with **encryption capability enabled**:
              * Label session
              * Label with previously set encryption key
              * Write without encryption
              * Read without encryption
              * Write with encryption
              * Read with encryption
              * Write with previously set encryption key
              * Read with previously set encryption key
            On drive with **encryption cabability disabled**:
              * Label session
              * Write without encryption
              * Read without encryption
              * Write with encryption - session **should** fail
              * Read with encryption - session **should** fail
          See merge request !3
        Secure session against invalid encryption script output
        Changes in encryption workflow
          - VMGR tag is updated only on write operations
          - Empty key signifies no encryption
        Minor encryption log enhancements
          * Error line in Read/Write session with ErrorMesage key
          * Fix for delimiter in the end of arguments in argsToString()
        Merging in improvements on tape encryption support.
        Removed nullptr which is not supported in SLC6's gcc.
        Added automatic deletion of json objects in
        Fix log typo
  11. 06 Oct, 2016 3 commits
    • Eric Cano's avatar
      Implemented drive status support in drive register structure and code. · 56c4c332
      Eric Cano authored
      Added drive status reporting in scheduler
      Added drive status reporting in OStoreDB
      Added support for drive status listing in the front end
      Removed virtual functions from the Scheduler, which is never overloaded.
      Added DesiredDriveState structure to drive state.
      Removed usage of duplicate MountType, DriveStatus and DriveState structures.
      Created DriveInfo structure to allow recreation of drive register entry in all
      reporting situation (potentially with partial/assumed info).
    • Victor Kotlyar's avatar
      Ported commit 2a14c5d7ef7bb395a37454789abcbfd7266edcc2 from castor/master · a4776842
      Victor Kotlyar authored
      CASTOR-4982: tapeserverd should tolerate some non-fatal tape alerts
      before writing
      Add logic to the TapeWriteSingleThread to skip not-fatal tape
      alerts before writing to the tape. Only "Lost statistics"
      tapeAlertLostStatistics 0x32 tolerated as non-fatal.
    • Victor Kotlyar's avatar
      Ported commit 01b32f6ffc3d28ec7681eff02973ba91191fcc60 castor/master · adfd407e
      Victor Kotlyar authored
      CASTOR-5042: The SCSI layer of the tape server overlooks SCSI errors
      not coming from the target
      Add output for all errors available for SCSI call.
      The logic implemented is to go through all errors in the following
      order: status, host_status, driver_status. In case of particular
      error an appropriate exception generated.
  12. 30 Sep, 2016 1 commit
    • Victor Kotlyar's avatar
      Ported commits from castor/master for general,drive,volume SCSI statistics: · e8b4ec34
      Victor Kotlyar authored
        CASTOR-5322 RFE: Enhance tapeserverd logs with SCSI tape drive
        Fix for mhtvl scsi log sense exceptions
        CASTOR-5329 Enhance tape statistics
        CASTOR-5332 RFE: Reduce log level to INFO with MHVTL - SCSI Statistics
          could not be acquired from drive
        Move volume SCSI statistics inside the dtor of TapeCleaningMove volume
          SCSI statistics inside the dtor of TapeCleaning
        ## Description
        When first introduced volume SCSI Statistics (at the moment
        IBM-specific), we explicitly put the function after the unmount of the
        tape was done due to an invalid file descriptor error occurring during
        the SCSI query.
        This bug no longer occurs for IBM drives.
        This may be attributed to the update of firmware of the IBM drives
        Apart from the change of the position of the changes, there is no
        alteration in terms of the metrics reported from the drive to the logs.
        ## Testing
        The tests the new code has been through are:
          * Write/Read file on IBM lib0 drive *(older one)*
          * Write/Read file on IBM lib4 drive *(newer one)*
          * Write/Read file on Oracle T10k drive
  13. 31 Aug, 2016 1 commit
  14. 29 Aug, 2016 1 commit
  15. 24 Feb, 2016 6 commits
  16. 19 Feb, 2016 1 commit