Commit ef0ca327 authored by Eric Cano's avatar Eric Cano
Browse files

bug #85285: tapegateway::WorkerThread::handleMigrationUpdate blindly sends a...

bug #85285: tapegateway::WorkerThread::handleMigrationUpdate blindly sends a positive acknowledgements

Fixed the failing VMGR update when the tape was disabled. Reduced the cases when the vmgr helper functions refuse to work.
The vmgr helper class of the tape gateway was heavily refactored in the process.
Also added a mechanism to prevent looping on vmgr in case of a shutdown of the demon.
This was implemented with a new functor in tape/utils.
Homogenized the authorship information in tape gateway directory (to castor-dev team).
parent b98762ea
......@@ -18,7 +18,7 @@ COMM along with this program; if not, write to the Free Software
COMM Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
COMM
COMM
COMM @author Giulia Taurelli, Giulia.Taurelli@cern.ch
COMM @author Castor Dev team, castor-dev@cern.ch
COMM
......
......@@ -23,7 +23,7 @@
*
*
*
* @author Giulia Taurelli
* @author Castor Dev team, castor-dev@cern.ch
*****************************************************************************/
#ifndef CASTOR_TAPE_TAPEGATEWAY_RETRYPOLICYELEMENT_HPP
......
......@@ -21,7 +21,7 @@
*
*
*
* @author Eric Cano
* @author Castor Dev team, castor-dev@cern.ch
*****************************************************************************/
#include "ScopedTransaction.hpp"
......
......@@ -21,7 +21,7 @@
*
*
*
* @author Eric Cano
* @author Castor Dev team, castor-dev@cern.ch
*****************************************************************************/
#ifndef SCOPEDTRANSACTION_HPP_
......
......@@ -22,7 +22,7 @@
*
*
*
* @author Giulia Taurelli gtaur@cern.ch
* @author Castor Dev team, castor-dev@cern.ch
*****************************************************************************/
#ifndef CASTOR_TAPE_TAPEGATEWAY_TAPEGATEWAYDLFMESSAGECONSTANTS_HPP
......@@ -148,7 +148,9 @@ LINKER_VMGR_NS_DISCREPANCY=112, /* "TapeStreamLinker: NS/VMGR mismatch for highe
WORKER_REPACK_STALE_FILE=113, /* "Worker: file changed during repack: nothing to do" */
WORKER_REPACK_UNCONFIRMED_STALE_FILE=114, /* "Worker: segment to repack is gone, but file change unconfirmed" */
WORKER_REPACK_FILE_REMOVED=115, /* "Worker: file no found on segment update for repack" */
WORKER_FAIL_NOTIFICATION_FOR_FILE=116 /* "Worker: received end notification error report for file" */
WORKER_FAIL_NOTIFICATION_FOR_FILE=116, /* "Worker: received end notification error report for file" */
CHECKER_CANNOT_RELEASE_TAPE=117, /* "VdqmRequestsChecker: cannot release BUSY tape after end transaction" */
VMGR_GATEWAY_HELPER_RETRYING=118 /* "VmgrTapeGatewayHelper::TapeInfo: will retry VMGR query" */
}; // enum TapeGatewayDlfMessages
} // namespace tapegateway
} // namespace tape
......
......@@ -19,7 +19,7 @@
*
*
*
* @author Giulia Taurelli gtaur@cern.ch
* @author Castor Dev team, castor-dev@cern.ch
*****************************************************************************/
#ifndef CASTOR_TAPE_TAPEGATEWAY_TAPEGATEWAYDLFMESSAGECONSTANTS_HPP
......
......@@ -145,4 +145,6 @@ castor::dlf::Message castor::tape::tapegateway::TapeGatewayDaemon::s_dlfMessages
{WORKER_REPACK_UNCONFIRMED_STALE_FILE, "Worker: segment to repack is gone, but file change unconfirmed"},
{WORKER_REPACK_FILE_REMOVED, "Worker: file no found on segment update for repack"},
{WORKER_FAIL_NOTIFICATION_FOR_FILE, "Worker: received end notification error report for file"},
{CHECKER_CANNOT_RELEASE_TAPE, "VdqmRequestsChecker: cannot release BUSY tape after end transaction"},
{VMGR_GATEWAY_HELPER_RETRYING, "VmgrTapeGatewayHelper::TapeInfo: will retry VMGR query"},
{-1, ""}};
......@@ -19,7 +19,7 @@
*
*
*
* @author Giulia Taurelli gtaur@cern.ch
* @author Castor Dev team, castor-dev@cern.ch
*****************************************************************************/
#include "castor/tape/tapegateway/TapeGatewayDlfMessageConstants.hpp"
......
......@@ -19,7 +19,7 @@
*
*
*
* @author Giulia Taurelli
* @author Castor Dev team, castor-dev@cern.ch
*****************************************************************************/
......
......@@ -21,7 +21,7 @@
*
* This class provides methods related to tape handling
*
* @author Giulia Taurelli
* @author Castor Dev team, castor-dev@cern.ch
*****************************************************************************/
#ifndef STAGER_ITAPEGATEWAYSVC_HPP
......
......@@ -21,7 +21,7 @@
*
*
*
* @author Giulia Taurelli
* @author Castor Dev team, castor-dev@cern.ch
*****************************************************************************/
// Include Python.h before any standard headers because Python.h may define
......
......@@ -22,7 +22,7 @@
*
*
*
* @author Giulia Taurelli
* @author Castor Dev team, castor-dev@cern.ch
*****************************************************************************/
#ifndef MIGRATORERRORHANDLER_THREAD_HPP
......
......@@ -19,7 +19,7 @@
*
*
*
* @author Nicola.Bessone@cern.ch Steven.Murray@cern.ch
* @author Castor Dev team, castor-dev@cern.ch
*****************************************************************************/
#include "castor/exception/Internal.hpp"
......
......@@ -19,7 +19,7 @@
*
*
*
* @author Nicola.Bessone@cern.ch Steven.Murray@cern.ch
* @author Castor Dev team, castor-dev@cern.ch
*****************************************************************************/
#ifndef CASTOR_TAPE_TAPEGATEWAY_DAEMON_MOUNTidTOFSEQMAP_HPP
......
......@@ -22,7 +22,7 @@
*
*
*
* @author Giulia Taurelli
* @author Castor Dev team, castor-dev@cern.ch
*****************************************************************************/
#include <common.h>
......
......@@ -21,7 +21,7 @@
*
*
*
* @author Giulia Taurelli
* @author Castor Dev team, castor-dev@cern.ch
*****************************************************************************/
// Include Python.h before any standard headers because Python.h may define
......
......@@ -22,7 +22,7 @@
*
*
*
* @author Giulia Taurelli
* @author Castor Dev team, castor-dev@cern.ch
*****************************************************************************/
#ifndef RECALLERERRORHANDLER_THREAD_HPP
......
......@@ -21,7 +21,7 @@
*
*
*
* @author Giulia Taurelli
* @author Castor Dev team, castor-dev@cern.ch
*****************************************************************************/
......
......@@ -22,7 +22,7 @@
*
*
*
* @author Giulia Taurelli
* @author Castor Dev team, castor-dev@cern.ch
*****************************************************************************/
......
......@@ -19,7 +19,7 @@
*
*
*
* @author Giulia Taurelli
* @author Castor Dev team, castor-dev@cern.ch
*****************************************************************************/
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment