From e96e1eae9195284df2d3fa97992b88e754239849 Mon Sep 17 00:00:00 2001
From: Eric Cano <Eric.Cano@cern.ch>
Date: Tue, 13 Nov 2018 16:07:51 +0100
Subject: [PATCH] Fixed comments
---
objectstore/ArchiveRequest.cpp | 3 +++
objectstore/RetrieveRequest.cpp | 11 -----------
2 files changed, 3 insertions(+), 11 deletions(-)
diff --git a/objectstore/ArchiveRequest.cpp b/objectstore/ArchiveRequest.cpp
index 54d143eb74..fd3145a6d3 100644
--- a/objectstore/ArchiveRequest.cpp
+++ b/objectstore/ArchiveRequest.cpp
@@ -151,6 +151,9 @@ auto ArchiveRequest::addTransferFailure(uint16_t copyNumber,
throw NoSuchJob ("In ArchiveRequest::addJobFailure(): could not find job");
}
+//------------------------------------------------------------------------------
+// ArchiveRequest::addReportFailure()
+//------------------------------------------------------------------------------
auto ArchiveRequest::addReportFailure(uint16_t copyNumber, uint64_t sessionId, const std::string& failureReason,
log::LogContext& lc) -> EnqueueingNextStep {
checkPayloadWritable();
diff --git a/objectstore/RetrieveRequest.cpp b/objectstore/RetrieveRequest.cpp
index 1fd833af40..c9c8d53203 100644
--- a/objectstore/RetrieveRequest.cpp
+++ b/objectstore/RetrieveRequest.cpp
@@ -582,17 +582,6 @@ std::string RetrieveRequest::eventToString(JobEvent jobEvent) {
//------------------------------------------------------------------------------
// RetrieveRequest::determineNextStep()
-//
-// We have to determine which next step should be taken:
-//
-// * When transfer succeeds or fails:
-// - If the job got transferred and is not the last (other(s) remain to transfer), it becomes complete.
-// - If the job failed and is not the last, we will queue it as "failed" in the failed jobs queue.
-// - If the job is the last and all jobs succeeded, this jobs becomes ToReportForTransfer
-// - If the job is the last and any (including this one) failed, this job becomes ToReportForFailure.
-//
-// * When report completes or fails:
-// - If the report was for a failure, the job is
//------------------------------------------------------------------------------
auto RetrieveRequest::determineNextStep(uint16_t copyNumberUpdated, JobEvent jobEvent,
log::LogContext& lc) -> EnqueueingNextStep
--
GitLab