diff --git a/common/checksum/ChecksumTest.cpp b/common/checksum/ChecksumTest.cpp index 88a3f64fa27ce9669cc34d09248ba116095f0170..5cc21fae76fae02335ab8302b594c10fee36477c 100644 --- a/common/checksum/ChecksumTest.cpp +++ b/common/checksum/ChecksumTest.cpp @@ -37,7 +37,7 @@ TEST_F(cta_ChecksumTest, default_constructor) { const Checksum checksum; ASSERT_EQ(Checksum::CHECKSUMTYPE_NONE, checksum.getType()); - ASSERT_TRUE(checksum.str().empty()); + ASSERT_EQ("-", checksum.str()); ASSERT_EQ((uint32_t)0, checksum.getByteArray().size()); } diff --git a/nameserver/mockNS/MockNameServer.cpp b/nameserver/mockNS/MockNameServer.cpp index a9dd6830ed60a911297a28f1ececd47dd62b71c9..7a4c400164c759dd6db2081b5094781004c8c99b 100644 --- a/nameserver/mockNS/MockNameServer.cpp +++ b/nameserver/mockNS/MockNameServer.cpp @@ -101,7 +101,7 @@ void cta::MockNameServer::assertChecksumOrSetIfMissing(const std::string &path, // if not // Get the existing checksum auto ec = Utils::getXattr(path, "user.CTAChecksum"); - if (ec.empty()) { + if (ec.empty() || ec == "-") { // Checksum not set: set it. Utils::setXattr(path, "user.CTAChecksum", checksum); } else if (ec != checksum) { @@ -215,8 +215,7 @@ void cta::MockNameServer::assertStorageClassIsNotInUse( std::string cta::MockNameServer::fromNameServerTapeFileToString(const cta::NameServerTapeFile &tapeFile) const { std::stringstream ss; - ss << tapeFile.checksum.checksumTypeToStr(tapeFile.checksum.getType()) - << " " << tapeFile.checksum.str() + ss << tapeFile.checksum.str() << " " << tapeFile.compressedSize << " " << tapeFile.copyNb << " " << tapeFile.size @@ -233,10 +232,8 @@ std::string cta::MockNameServer::fromNameServerTapeFileToString(const cta::NameS cta::NameServerTapeFile cta::MockNameServer::fromStringToNameServerTapeFile(const std::string &xAttributeString) const { NameServerTapeFile tapeFile; std::stringstream ss(xAttributeString); - std::string checksumTypeString; - uint32_t checksumInt32; - ss >> checksumTypeString - >> checksumInt32 + std::string checksumString; + ss >> checksumString >> tapeFile.compressedSize >> tapeFile.copyNb >> tapeFile.size @@ -244,8 +241,7 @@ cta::NameServerTapeFile cta::MockNameServer::fromStringToNameServerTapeFile(cons >> tapeFile.tapeFileLocation.copyNb >> tapeFile.tapeFileLocation.fSeq >> tapeFile.tapeFileLocation.vid; - cta::Checksum::ChecksumType checksumType=checksumTypeString=="ADLER32"?cta::Checksum::ChecksumType::CHECKSUMTYPE_ADLER32:cta::Checksum::ChecksumType::CHECKSUMTYPE_NONE; - cta::Checksum checksum(checksumType, checksumInt32); + cta::Checksum checksum(checksumString); tapeFile.checksum=checksum; return tapeFile; }