From 9dc6e49e65dfe675a5e227758e0da1fcaac9901e Mon Sep 17 00:00:00 2001
From: Julien Leduc <julien.leduc@cern.ch>
Date: Thu, 20 Jul 2017 12:12:50 +0200
Subject: [PATCH] Setting `imagePullSecrets` to `ctaregsecret` for all pods
 This allows to solve the recurrent docker login issue by passing the
 credentials to kubernetes as a secret. Indeed docker login credentials are
 valid for 3 months then it is over. We just need to pass the `ctareg` service
 account credentials in the `ctaregsecrets` and we are done. In addition
 `imagePullSecrets` works at the full cluster level as each kubelet needs the
 registry credentials to pull its own image. If `ctaregsecret` secret does not
 exists, kubernetes is perfectly fine with that and uses the default
 authentication. This means that there is no need to define this secret (which
 is useless in the buildtree environment).

---
 continuousintegration/orchestration/pod-client.yaml      | 3 +++
 continuousintegration/orchestration/pod-ctacli.yaml      | 3 +++
 continuousintegration/orchestration/pod-ctaeos.yaml      | 3 +++
 continuousintegration/orchestration/pod-ctafrontend.yaml | 3 +++
 continuousintegration/orchestration/pod-init.yaml        | 3 +++
 continuousintegration/orchestration/pod-kdc.yaml         | 3 +++
 continuousintegration/orchestration/pod-tpsrv.yaml       | 3 +++
 continuousintegration/orchestration/pod-tpsrv01.yaml     | 3 +++
 continuousintegration/orchestration/pod-tpsrv02.yaml     | 3 +++
 9 files changed, 27 insertions(+)

diff --git a/continuousintegration/orchestration/pod-client.yaml b/continuousintegration/orchestration/pod-client.yaml
index bd535dc1c5..52657c480c 100644
--- a/continuousintegration/orchestration/pod-client.yaml
+++ b/continuousintegration/orchestration/pod-client.yaml
@@ -50,3 +50,6 @@ spec:
   - name: logstorage
     persistentVolumeClaim:
       claimName: claimlogs
+
+  imagePullSecrets:
+  - name: ctaregsecret
diff --git a/continuousintegration/orchestration/pod-ctacli.yaml b/continuousintegration/orchestration/pod-ctacli.yaml
index f0d313a7f9..c5f3dd2a0b 100644
--- a/continuousintegration/orchestration/pod-ctacli.yaml
+++ b/continuousintegration/orchestration/pod-ctacli.yaml
@@ -50,3 +50,6 @@ spec:
   - name: logstorage
     persistentVolumeClaim:
       claimName: claimlogs
+
+  imagePullSecrets:
+  - name: ctaregsecret
diff --git a/continuousintegration/orchestration/pod-ctaeos.yaml b/continuousintegration/orchestration/pod-ctaeos.yaml
index debdf1f56a..10c5663e4e 100644
--- a/continuousintegration/orchestration/pod-ctaeos.yaml
+++ b/continuousintegration/orchestration/pod-ctaeos.yaml
@@ -57,3 +57,6 @@ spec:
   - name: stgstorage
     persistentVolumeClaim:
       claimName: claimstg
+
+  imagePullSecrets:
+  - name: ctaregsecret
diff --git a/continuousintegration/orchestration/pod-ctafrontend.yaml b/continuousintegration/orchestration/pod-ctafrontend.yaml
index 09acb3659b..28427f0b2f 100644
--- a/continuousintegration/orchestration/pod-ctafrontend.yaml
+++ b/continuousintegration/orchestration/pod-ctafrontend.yaml
@@ -69,3 +69,6 @@ spec:
   - name: logstorage
     persistentVolumeClaim:
       claimName: claimlogs
+
+  imagePullSecrets:
+  - name: ctaregsecret
diff --git a/continuousintegration/orchestration/pod-init.yaml b/continuousintegration/orchestration/pod-init.yaml
index 3c8bce4b8c..9e933c9130 100644
--- a/continuousintegration/orchestration/pod-init.yaml
+++ b/continuousintegration/orchestration/pod-init.yaml
@@ -73,3 +73,6 @@ spec:
   - name: logstorage
     persistentVolumeClaim:
       claimName: claimlogs
+
+  imagePullSecrets:
+  - name: ctaregsecret
diff --git a/continuousintegration/orchestration/pod-kdc.yaml b/continuousintegration/orchestration/pod-kdc.yaml
index 079e72c492..e111aa4492 100644
--- a/continuousintegration/orchestration/pod-kdc.yaml
+++ b/continuousintegration/orchestration/pod-kdc.yaml
@@ -40,3 +40,6 @@ spec:
   - name: logstorage
     persistentVolumeClaim:
       claimName: claimlogs
+
+  imagePullSecrets:
+  - name: ctaregsecret
diff --git a/continuousintegration/orchestration/pod-tpsrv.yaml b/continuousintegration/orchestration/pod-tpsrv.yaml
index aa19be1c35..9c851b8678 100644
--- a/continuousintegration/orchestration/pod-tpsrv.yaml
+++ b/continuousintegration/orchestration/pod-tpsrv.yaml
@@ -109,3 +109,6 @@ spec:
   - name: logstorage
     persistentVolumeClaim:
       claimName: claimlogs
+
+  imagePullSecrets:
+  - name: ctaregsecret
diff --git a/continuousintegration/orchestration/pod-tpsrv01.yaml b/continuousintegration/orchestration/pod-tpsrv01.yaml
index 3ef7569460..687e29866e 100644
--- a/continuousintegration/orchestration/pod-tpsrv01.yaml
+++ b/continuousintegration/orchestration/pod-tpsrv01.yaml
@@ -113,3 +113,6 @@ spec:
   - name: logstorage
     persistentVolumeClaim:
       claimName: claimlogs
+
+  imagePullSecrets:
+  - name: ctaregsecret
diff --git a/continuousintegration/orchestration/pod-tpsrv02.yaml b/continuousintegration/orchestration/pod-tpsrv02.yaml
index 959946a3cc..5387cfe1fb 100644
--- a/continuousintegration/orchestration/pod-tpsrv02.yaml
+++ b/continuousintegration/orchestration/pod-tpsrv02.yaml
@@ -113,3 +113,6 @@ spec:
   - name: logstorage
     persistentVolumeClaim:
       claimName: claimlogs
+
+  imagePullSecrets:
+  - name: ctaregsecret
-- 
GitLab