diff --git a/ReleaseNotes.md b/ReleaseNotes.md index 4428b7a35ddceda5167efe67931b9d506835da2e..6961f5a77c85bcd459971b88cb2d48667c1d3d1b 100644 --- a/ReleaseNotes.md +++ b/ReleaseNotes.md @@ -1,3 +1,11 @@ +# v.NEXT + +## Summary +### Features + +### Bug Fixes +- cta/CTA#234 - Replace stoi with toUint64 in standalone cli tool + # v4.8.2-1 ## Summary diff --git a/cmdline/standalone_cli_tools/change_storage_class/ChangeStorageClass.cpp b/cmdline/standalone_cli_tools/change_storage_class/ChangeStorageClass.cpp index f57d441ef8d1c70a1d040815d2f9ca97c6e0ea44..a8ff83a083a5baacc50c041e522ba46b0793ed4b 100644 --- a/cmdline/standalone_cli_tools/change_storage_class/ChangeStorageClass.cpp +++ b/cmdline/standalone_cli_tools/change_storage_class/ChangeStorageClass.cpp @@ -128,7 +128,7 @@ void ChangeStorageClass::updateStorageClassInEosNamespace() { const auto [diskInstance, diskFileId] = CatalogueFetch::getInstanceAndFid(archiveFileId, m_serviceProviderPtr, m_log); // No files in flight should change storage class - const auto md_response = m_endpointMapPtr->getMD(diskInstance, ::eos::rpc::FILE, std::stoi(diskFileId), "", false); + const auto md_response = m_endpointMapPtr->getMD(diskInstance, ::eos::rpc::FILE, cta::utils::toUint64(diskFileId), "", false); if (fileInFlight(md_response.fmd().locations())) { m_archiveIdsNotUpdatedInEos.push_back(archiveFileId); std::list<cta::log::Param> params; diff --git a/cmdline/standalone_cli_tools/common/CatalogueFetch.cpp b/cmdline/standalone_cli_tools/common/CatalogueFetch.cpp index dca86898786763ffa8913c2b70cc04bc747e2898..fa8b39c85d1e12550a9fff9868e0f1b04d8c70a3 100644 --- a/cmdline/standalone_cli_tools/common/CatalogueFetch.cpp +++ b/cmdline/standalone_cli_tools/common/CatalogueFetch.cpp @@ -26,6 +26,7 @@ #include "cmdline/standalone_cli_tools/common/CatalogueFetch.hpp" #include "common/exception/UserError.hpp" #include "common/log/StdoutLogger.hpp" +#include "common/utils/utils.hpp" #include "cta_frontend.pb.h" //!< Auto-generated message types from .proto file #include "version.h" @@ -119,7 +120,7 @@ std::tuple<std::string,std::string> CatalogueFetch::getInstanceAndFid(const std: admincmd->set_subcmd(cta::admin::AdminCmd::SUBCMD_LS); auto new_opt = admincmd->add_option_uint64(); new_opt->set_key(cta::admin::OptionUInt64::ARCHIVE_FILE_ID); - new_opt->set_value(std::stoi(archiveFileId)); + new_opt->set_value(cta::utils::toUint64(archiveFileId)); handleResponse(request, serviceProviderPtr); diff --git a/cmdline/standalone_cli_tools/restore_files/RestoreFilesCmd.cpp b/cmdline/standalone_cli_tools/restore_files/RestoreFilesCmd.cpp index bd8e3bf0cd3eb51c1ebdea1e8131fb715e9eb1f6..d668d63d89c0ab253d81f067189cb03babde7d31 100644 --- a/cmdline/standalone_cli_tools/restore_files/RestoreFilesCmd.cpp +++ b/cmdline/standalone_cli_tools/restore_files/RestoreFilesCmd.cpp @@ -237,7 +237,7 @@ void RestoreFilesCmd::listDeletedFilesCta() const { auto key = cta::admin::OptionUInt64::ARCHIVE_FILE_ID; auto new_opt = admincmd.add_option_uint64(); new_opt->set_key(key); - new_opt->set_value(std::stoi(m_archiveFileId.value())); + new_opt->set_value(cta::utils::toUint64(m_archiveFileId.value())); } if (m_copyNumber) { params.push_back(cta::log::Param("copyNb", m_copyNumber.value()));