Commit 767a4f90 authored by Eric Cano's avatar Eric Cano
Browse files

Log messages and code comments clarifications

parent 511174b4
......@@ -86,7 +86,8 @@ bool RecallTaskInjector::synchronousInjection(uint64_t maxFiles, uint64_t byteSi
{
client::ClientProxy::RequestReport reqReport;
std::auto_ptr<castor::tape::tapegateway::FilesToRecallList> filesToRecallList(m_client.getFilesToRecall(maxFiles,byteSizeThreshold,reqReport));
std::auto_ptr<castor::tape::tapegateway::FilesToRecallList>
filesToRecallList(m_client.getFilesToRecall(maxFiles,byteSizeThreshold,reqReport));
LogContext::ScopedParam sp[]={
LogContext::ScopedParam(m_lc, Param("maxFiles", maxFiles)),
LogContext::ScopedParam(m_lc, Param("byteSizeThreshold",byteSizeThreshold)),
......@@ -97,7 +98,7 @@ bool RecallTaskInjector::synchronousInjection(uint64_t maxFiles, uint64_t byteSi
tape::utils::suppresUnusedVariable(sp);
if(NULL==filesToRecallList.get()) {
m_lc.log(LOG_ERR, "Get called but no files to retrieve");
m_lc.log(LOG_ERR, "No files to recall: empty mount");
return false;
}
else {
......
......@@ -56,7 +56,7 @@ public:
/**
* Function for a feed-back loop purpose between RecallTaskInjector and
* DiskWriteThreadPool. When DiskWriteThreadPool::popAndRequestMoreJobs detects
* TapeReadSingleThread. When TapeReadSingleThread::popAndRequestMoreJobs detects
* it has not enough jobs to do to, it is class to push a request
* in order to (try) fill up the queue.
* @param maxFiles files count requested.
......@@ -66,6 +66,12 @@ public:
*/
virtual void requestInjection(int maxFiles, int byteSizeThreshold, bool lastCall);
/**
* Send an end token in the request queue. There should be no subsequent
* calls to requestInjection.
*/
void finish();
/**
* Contact the client to make sure there are really something to do
* Something = recall at most maxFiles or at least maxBytes
......@@ -85,8 +91,6 @@ public:
* Start the inner thread
*/
void startThreads();
void finish();
private:
/**
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment