Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
dCache
cta
Commits
11cc04b8
Commit
11cc04b8
authored
Nov 12, 2020
by
Cedric Caffy
Browse files
Transformed unuseful WARNING log messages to DEBUG
parent
6f991efa
Pipeline
#2812
passed with stage
in 2 minutes and 18 seconds
Changes
4
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
ReleaseNotes.md
View file @
11cc04b8
...
...
@@ -4,6 +4,10 @@
This version contains different bug fixes
### Features
Unuseful WARNING logs are now DEBUG logs
### Bug fixes
cta/CTA#837 Repack now fails if the repack buffer VID directory cannot be created during expansion
...
...
cta.spec.in
View file @
11cc04b8
...
...
@@ -494,6 +494,7 @@ Currently contains a helper for the client-ar script, which should be installed
- cta/CTA#837 Repack now fails if the repack buffer VID directory cannot be created during expansion
- cta/CTA#920 Archive and Retrieve error report URL correction on the cta-send-event cmdline tool
- cta/CTA#923 Corrected the cta-admin showqueues command to display all the retrieve queues of tapes that are on the same tapepool
- Unuseful WARNING logs are now DEBUG logs
* Wed Nov 04 2020 julien.leduc (at) cern.ch - 3.1-9
- Upstream EOS 4.8.26-1
- cta/CTA#907 For backpressure, the EOS free space can be fetched by calling an external script
...
...
scheduler/OStoreDB/OStoreDB.cpp
View file @
11cc04b8
...
...
@@ -207,7 +207,7 @@ void OStoreDB::fetchMountInfo(SchedulerDatabase::TapeMountDecisionInfo& tmdi, Ro
params
.
add
(
"queueObject"
,
aqp
.
address
)
.
add
(
"tapePool"
,
aqp
.
tapePool
)
.
add
(
"exceptionMessage"
,
ex
.
getMessageValue
());
logContext
.
log
(
log
::
WARNING
,
"
In OStoreDB::fetchMountInfo(): failed to lock/fetch an archive queue for user. Skipping it."
);
logContext
.
log
(
log
::
DEBUG
,
"
WARNING
:
In OStoreDB::fetchMountInfo(): failed to lock/fetch an archive queue for user. Skipping it."
);
continue
;
}
// If there are files queued, we create an entry for this tape pool in the
...
...
@@ -269,7 +269,7 @@ void OStoreDB::fetchMountInfo(SchedulerDatabase::TapeMountDecisionInfo& tmdi, Ro
params
.
add
(
"queueObject"
,
aqp
.
address
)
.
add
(
"tapePool"
,
aqp
.
tapePool
)
.
add
(
"exceptionMessage"
,
ex
.
getMessageValue
());
logContext
.
log
(
log
::
WARNING
,
"
In OStoreDB::fetchMountInfo(): failed to lock/fetch an archive queue for repack. Skipping it."
);
logContext
.
log
(
log
::
DEBUG
,
"
WARNING
:
In OStoreDB::fetchMountInfo(): failed to lock/fetch an archive queue for repack. Skipping it."
);
continue
;
}
// If there are files queued, we create an entry for this tape pool in the
...
...
@@ -331,7 +331,7 @@ void OStoreDB::fetchMountInfo(SchedulerDatabase::TapeMountDecisionInfo& tmdi, Ro
params
.
add
(
"queueObject"
,
rqp
.
address
)
.
add
(
"tapeVid"
,
rqp
.
vid
)
.
add
(
"exceptionMessage"
,
ex
.
getMessageValue
());
lc
.
log
(
log
::
WARNING
,
"
In OStoreDB::fetchMountInfo(): failed to lock/fetch a retrieve queue. Skipping it."
);
lc
.
log
(
log
::
DEBUG
,
"
WARNING
:
In OStoreDB::fetchMountInfo(): failed to lock/fetch a retrieve queue. Skipping it."
);
continue
;
}
// If there are files queued, we create an entry for this retrieve queue in the
...
...
@@ -1011,7 +1011,7 @@ SchedulerDatabase::JobsFailedSummary OStoreDB::getArchiveJobsFailedSummary(log::
log
::
ScopedParamContainer
params
(
logContext
);
params
.
add
(
"queueObject"
,
aj
.
address
)
.
add
(
"exceptionMessage"
,
ex
.
getMessageValue
());
logContext
.
log
(
log
::
WARNING
,
"
In OStoreDB::getArchiveJobsFailedSummary(): failed to lock/fetch an archive queue."
);
logContext
.
log
(
log
::
DEBUG
,
"
WARNING
:
In OStoreDB::getArchiveJobsFailedSummary(): failed to lock/fetch an archive queue."
);
continue
;
}
auto
summary
=
aq
.
getCandidateSummary
();
...
...
@@ -3001,7 +3001,7 @@ SchedulerDatabase::JobsFailedSummary OStoreDB::getRetrieveJobsFailedSummary(log:
log
::
ScopedParamContainer
params
(
logContext
);
params
.
add
(
"queueObject"
,
rj
.
address
)
.
add
(
"exceptionMessage"
,
ex
.
getMessageValue
());
logContext
.
log
(
log
::
WARNING
,
"
In OStoreDB::getRetrieveJobsFailedSummary(): failed to lock/fetch a retrieve queue."
);
logContext
.
log
(
log
::
DEBUG
,
"
WARNING
:
In OStoreDB::getRetrieveJobsFailedSummary(): failed to lock/fetch a retrieve queue."
);
continue
;
}
auto
summary
=
rq
.
getCandidateSummary
();
...
...
tapeserver/daemon/DriveHandler.cpp
View file @
11cc04b8
...
...
@@ -448,8 +448,8 @@ SubprocessHandler::ProcessingStatus DriveHandler::processChecking(serializers::W
.
add
(
"PreviousType"
,
session
::
toString
(
m_sessionType
))
.
add
(
"NewState"
,
session
::
toString
((
SessionState
)
message
.
sessionstate
()))
.
add
(
"NewType"
,
session
::
toString
((
SessionType
)
message
.
sessiontype
()));
m_processManager
.
logContext
().
log
(
log
::
WARNIN
G
,
"In DriveHandler::processChecking(): unexpected previous state/type."
);
m_processManager
.
logContext
().
log
(
log
::
DEBU
G
,
"
WARNING:
In DriveHandler::processChecking(): unexpected previous state/type."
);
}
else
if
(
m_sessionState
!=
SessionState
::
Checking
)
{
// If we see a session state change, it's worth logging (at least in debug mode)
params
.
add
(
"PreviousState"
,
session
::
toString
(
m_sessionState
))
...
...
@@ -484,8 +484,8 @@ SubprocessHandler::ProcessingStatus DriveHandler::processMounting(serializers::W
.
add
(
"PreviousType"
,
session
::
toString
(
m_sessionType
))
.
add
(
"NewState"
,
session
::
toString
((
SessionState
)
message
.
sessionstate
()))
.
add
(
"NewType"
,
session
::
toString
((
SessionType
)
message
.
sessiontype
()));
m_processManager
.
logContext
().
log
(
log
::
WARNIN
G
,
"In DriveHandler::processMounting(): unexpected previous state/type."
);
m_processManager
.
logContext
().
log
(
log
::
DEBU
G
,
"
WARNING:
In DriveHandler::processMounting(): unexpected previous state/type."
);
}
else
if
(
m_sessionState
!=
SessionState
::
Checking
)
{
// If we see a session state change, it's worth logging (at least in debug mode)
params
.
add
(
"PreviousState"
,
session
::
toString
(
m_sessionState
))
...
...
@@ -523,8 +523,8 @@ SubprocessHandler::ProcessingStatus DriveHandler::processRunning(serializers::Wa
.
add
(
"PreviousType"
,
session
::
toString
(
m_sessionType
))
.
add
(
"NewState"
,
session
::
toString
((
SessionState
)
message
.
sessionstate
()))
.
add
(
"NewType"
,
session
::
toString
((
SessionType
)
message
.
sessiontype
()));
m_processManager
.
logContext
().
log
(
log
::
WARNIN
G
,
"In DriveHandler::processMounting(): unexpected previous state/type."
);
m_processManager
.
logContext
().
log
(
log
::
DEBU
G
,
"
WARNING:
In DriveHandler::processMounting(): unexpected previous state/type."
);
}
else
if
(
m_sessionState
!=
SessionState
::
Checking
)
{
// If we see a session state change, it's worth logging (at least in debug mode)
params
.
add
(
"PreviousState"
,
session
::
toString
(
m_sessionState
))
...
...
@@ -571,8 +571,8 @@ SubprocessHandler::ProcessingStatus DriveHandler::processUnmounting(serializers:
.
add
(
"PreviousType"
,
session
::
toString
(
m_sessionType
))
.
add
(
"NewState"
,
session
::
toString
((
SessionState
)
message
.
sessionstate
()))
.
add
(
"NewType"
,
session
::
toString
((
SessionType
)
message
.
sessiontype
()));
m_processManager
.
logContext
().
log
(
log
::
WARNIN
G
,
"In DriveHandler::processUnmounting(): unexpected previous state/type."
);
m_processManager
.
logContext
().
log
(
log
::
DEBU
G
,
"
WARNING:
In DriveHandler::processUnmounting(): unexpected previous state/type."
);
}
m_sessionState
=
(
SessionState
)
message
.
sessionstate
();
m_sessionType
=
(
SessionType
)
message
.
sessiontype
();
...
...
@@ -597,8 +597,8 @@ SubprocessHandler::ProcessingStatus DriveHandler::processDrainingToDisk(serializ
.
add
(
"PreviousType"
,
session
::
toString
(
m_sessionType
))
.
add
(
"NewState"
,
session
::
toString
((
SessionState
)
message
.
sessionstate
()))
.
add
(
"NewType"
,
session
::
toString
((
SessionType
)
message
.
sessiontype
()));
m_processManager
.
logContext
().
log
(
log
::
WARNIN
G
,
"In DriveHandler::processDrainingToDisk(): unexpected previous state/type."
);
m_processManager
.
logContext
().
log
(
log
::
DEBU
G
,
"
WARNING:
In DriveHandler::processDrainingToDisk(): unexpected previous state/type."
);
}
m_sessionState
=
(
SessionState
)
message
.
sessionstate
();
m_sessionType
=
(
SessionType
)
message
.
sessiontype
();
...
...
@@ -623,8 +623,8 @@ SubprocessHandler::ProcessingStatus DriveHandler::processShutingDown(serializers
.
add
(
"PreviousType"
,
session
::
toString
(
m_sessionType
))
.
add
(
"NewState"
,
session
::
toString
((
SessionState
)
message
.
sessionstate
()))
.
add
(
"NewType"
,
session
::
toString
((
SessionType
)
message
.
sessiontype
()));
m_processManager
.
logContext
().
log
(
log
::
WARNIN
G
,
"In DriveHandler::processShutingDown(): unexpected previous state/type."
);
m_processManager
.
logContext
().
log
(
log
::
DEBU
G
,
"
WARNING:
In DriveHandler::processShutingDown(): unexpected previous state/type."
);
}
m_sessionState
=
(
SessionState
)
message
.
sessionstate
();
m_sessionType
=
(
SessionType
)
message
.
sessiontype
();
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment