Fixed mixed-up and missing end of session statuses.

castor/tape/tapeserver/daemon/CatalogueTransferSession.cpp

@@ -259,7 +259,7 @@ void castor::tape::tapeserver::daemon::CatalogueTransferSession::
 void castor::tape::tapeserver::daemon::CatalogueTransferSession::
   sessionFailed() {
   // In case of problem, we mark the session failed ourselves
-  m_sessionLogContext.pushOrReplace(log::Param("status","failed"));
+  m_sessionLogContext.pushOrReplace(log::Param("status","failure"));
   m_sessionLogContext.log(LOG_INFO, "Tape session finished");
 }
 

castor/tape/tapeserver/daemon/MigrationReportPacker.cpp

@@ -248,7 +248,7 @@ void MigrationReportPacker::ReportEndofSession::execute(MigrationReportPacker& r
       .add("transactionId", chrono.transactionId);
     reportPacker.m_lc.log(LOG_INFO,"Reported end of session to client");
     if(reportPacker.m_watchdog) {
-      reportPacker.m_watchdog->addParameter(log::Param("status","failure"));
+      reportPacker.m_watchdog->addParameter(log::Param("status","success"));
     }
   }
   else {
@@ -263,7 +263,7 @@ void MigrationReportPacker::ReportEndofSession::execute(MigrationReportPacker& r
       .add("transactionId", chrono.transactionId);
     reportPacker.m_lc.log(LOG_ERR,"Reported end of session with error to client due to previous file errors");
     if(reportPacker.m_watchdog) {
-      reportPacker.m_watchdog->addParameter(log::Param("status","success"));
+      reportPacker.m_watchdog->addParameter(log::Param("status","failure"));
     }
   }
   reportPacker.m_continue=false;

castor/tape/tapeserver/daemon/RecallReportPacker.cpp

@@ -154,7 +154,7 @@ void RecallReportPacker::ReportEndofSession::execute(RecallReportPacker& parent)
       parent.m_client.reportEndOfSession(chrono);
       parent.logRequestReport(chrono,"Nominal RecallReportPacker::EndofSession has been reported",LOG_INFO);
       if (parent.m_watchdog) {
-        parent.m_watchdog->addParameter(log::Param("status","failure"));
+        parent.m_watchdog->addParameter(log::Param("status","success"));
       }
     }
     else {
@@ -162,6 +162,9 @@ void RecallReportPacker::ReportEndofSession::execute(RecallReportPacker& parent)
       parent.m_lc.log(LOG_ERR,msg);
       parent.m_client.reportEndOfSessionWithError(msg,SEINTERNAL,chrono);
       parent.logRequestReport(chrono,"reporting EndOfSessionWithError done",LOG_ERR);
+      if (parent.m_watchdog) {
+        parent.m_watchdog->addParameter(log::Param("status","failure"));
+      }
     }
 }
 //------------------------------------------------------------------------------
@@ -179,6 +182,9 @@ void RecallReportPacker::ReportEndofSessionWithErrors::execute(RecallReportPacke
    parent.m_lc.log(LOG_ERR,msg);
    parent.m_client.reportEndOfSessionWithError(msg,SEINTERNAL,chrono); 
   }
+  if (parent.m_watchdog) {
+    parent.m_watchdog->addParameter(log::Param("status","failure"));
+  }
 }
 //------------------------------------------------------------------------------
 //ReportError::execute