clang Warnings with new JavaNativeAccessWrappers
@claus.kleinwort found these warnings on his MacBook while testing !2 (merged) . The full output is fairly long so I'll just list the items that jump out to me.
- The
definedmacro has "undefined behavior". This warning accounts for most of the printouts - I'll need to research into this to see how to avoid it. - Comparison of
std::size_tandintin a loop. This is becauseintcan be negative andstd::size_tcan't be. Can avoid this by aligning types. -
ptr_array_to_vectorhas C-linkage but uses a user-defined type. I think this can be avoided by moving that vector out of theextern "C"block. -
points_2andnpoints_2are unused parameters. This is definitely a typo on my part that got past my testing. -
levelis an unused parameter. Probably can remove ifprintTrajectorydoes not use thelevelparameter anymore. - unused variable
out- probably can remove.
I can work on drafting patches to resolve these warnings, but since I don't have a MacBook I'll need help testing that these patches function as intended.