clang Warnings with new JavaNativeAccessWrappers
@claus.kleinwort found these warnings on his MacBook while testing !2 (merged) . The full output is fairly long so I'll just list the items that jump out to me.
- The
defined
macro has "undefined behavior". This warning accounts for most of the printouts - I'll need to research into this to see how to avoid it. - Comparison of
std::size_t
andint
in a loop. This is becauseint
can be negative andstd::size_t
can't be. Can avoid this by aligning types. -
ptr_array_to_vector
has C-linkage but uses a user-defined type. I think this can be avoided by moving that vector out of theextern "C"
block. -
points_2
andnpoints_2
are unused parameters. This is definitely a typo on my part that got past my testing. -
level
is an unused parameter. Probably can remove ifprintTrajectory
does not use thelevel
parameter anymore. - unused variable
out
- probably can remove.
I can work on drafting patches to resolve these warnings, but since I don't have a MacBook I'll need help testing that these patches function as intended.