deviceEigerP11.py: add logging and remove hard-coded value

kamzik3/devices/deviceEigerP11.py

@@ -171,12 +171,17 @@ class DeviceTangoEigerDetector(DeviceTango):
         )
 
         converted_exposure = self.detector.to_device_unit("FrameTime", Exposure)
-        frame_time = (
-            10e-3
-            if converted_exposure
-            < (1 / MAX_ACQUISITION_RATE).to(self.get_value("FrameTime", key=UNIT))
-            else float(converted_exposure.m)
+        min_frame_time = (1 / MAX_ACQUISITION_RATE).to(
+            self.get_value("FrameTime", key=UNIT)
         )
+        if converted_exposure < min_frame_time:
+            self.logger.error(
+                f"Can't acquire data faster than {MAX_ACQUISITION_RATE}, "
+                "defaulting to it"
+            )
+            frame_time = min_frame_time.m
+        else:
+            frame_time = float(converted_exposure.m)
 
         self.set_attribute(["TriggerMode", VALUE], TriggerMode.INTS.value)
         self.set_attribute(["FrameTime", VALUE], frame_time)
@@ -213,12 +218,17 @@ class DeviceTangoEigerDetector(DeviceTango):
             )
 
         converted_exposure = self.detector.to_device_unit("FrameTime", Exposure)
-        frame_time = (
-            10e-3
-            if converted_exposure
-            < (1 / MAX_ACQUISITION_RATE).to(self.get_value("FrameTime", key=UNIT))
-            else float(converted_exposure.m)
+        min_frame_time = (1 / MAX_ACQUISITION_RATE).to(
+            self.get_value("FrameTime", key=UNIT)
         )
+        if converted_exposure < min_frame_time:
+            self.logger.error(
+                f"Can't acquire data faster than {MAX_ACQUISITION_RATE}, "
+                "defaulting to it"
+            )
+            frame_time = min_frame_time.m
+        else:
+            frame_time = float(converted_exposure.m)
 
         self.set_attribute(["FrameTime", VALUE], frame_time)
         self.set_attribute(["CountTime", VALUE], float(converted_exposure.m))
@@ -416,14 +426,17 @@ class EigerSwScanner(DeviceScanner):
         converted_exposure = units.Quantity(params["Exposure"]).to(
             self.detector.get_value("FrameTime", key=UNIT)
         )
-        frame_time = (
-            10e-3
-            if converted_exposure
-            < (1 / MAX_ACQUISITION_RATE).to(
-                self.detector.get_value("FrameTime", key=UNIT)
-            )
-            else float(converted_exposure.m)
+        min_frame_time = (1 / MAX_ACQUISITION_RATE).to(
+            self.get_value("FrameTime", key=UNIT)
         )
+        if converted_exposure < min_frame_time:
+            self.logger.error(
+                f"Can't acquire data faster than {MAX_ACQUISITION_RATE}, "
+                "defaulting to it"
+            )
+            frame_time = min_frame_time.m
+        else:
+            frame_time = float(converted_exposure.m)
 
         self.detector.set_attribute(["FrameTime", VALUE], frame_time)
         self.detector.set_attribute(["CountTime", VALUE], float(converted_exposure.m))